You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/08/06 22:30:40 UTC
[GitHub] [helix] junkaixue opened a new pull request #1835: Fix test logic for testExternalViewDiffFromTargetExternalView
junkaixue opened a new pull request #1835:
URL: https://github.com/apache/helix/pull/1835
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
fixes #1825
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
The intermediate output does not match IdealState any more, since per replica throttling applied. So the generated TEV should be the target state of message.
### Tests
- [ ] The following tests are written for this issue:
- The following is the result of the "mvn test" command on the appropriate module:
Run 253 times for this tests. Pretty stable now.
************ SYSTEM Physical Memory:33566789632
************ total memory:3925 free memory:3129
---------- Test Class TestRoutingTableProviderFromTargetEV thread leakage detected! ---------------
Shut down zookeeper at port 2183 in thread main
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.386 s - in org.apache.helix.integration.spectator.TestRoutingTableProviderFromTargetEV
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.6:report (generate-code-coverage-report) @ helix-core ---
[INFO] Loading execution data file /home/jxue/helix/helix-core/target/jacoco.exec
[INFO] Analyzed bundle 'Apache Helix :: Core' with 911 classes
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19.722 s
[INFO] Finished at: 2021-08-06T15:27:28-07:00
[INFO] Final Memory: 44M/1059M
[INFO] ------------------------------------------------------------------------
======================================================================
Attempt 253 TestRoutingTableProviderFromTargetEV
======================================================================
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
### Documentation (Optional)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue merged pull request #1835: Fix test logic for testExternalViewDiffFromTargetExternalView
Posted by GitBox <gi...@apache.org>.
junkaixue merged pull request #1835:
URL: https://github.com/apache/helix/pull/1835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org