You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/06/05 05:03:00 UTC

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #3856: drivers: serial: Remove an unnecessary critical section for SMP

masayuki2009 opened a new pull request #3856:
URL: https://github.com/apache/incubator-nuttx/pull/3856


   ## Summary
   
   - Since the caller already holds xmit.sem in uart_write(),
     this critical section in serial.c is unnecessary for SMP
   
   ## Impact
   
   - None
   
   ## Testing
   
   - Tested with spresense:wifi_smp, esp32-devkitc:smp
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #3856: drivers: serial: Remove an unnecessary critical section for SMP

Posted by GitBox <gi...@apache.org>.

masayuki2009 commented on pull request #3856:
URL: https://github.com/apache/incubator-nuttx/pull/3856#issuecomment-855188355


   @xiaoxiang781216 
   
   I've created a new PR which we discussed at https://github.com/apache/incubator-nuttx/commit/dacd041a94b4150a90b401ef2098ae0015c7fa97#r51648725
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 closed pull request #3856: drivers: serial: Remove an unnecessary critical section for SMP

Posted by GitBox <gi...@apache.org>.

masayuki2009 closed pull request #3856:
URL: https://github.com/apache/incubator-nuttx/pull/3856


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #3856: drivers: serial: Remove an unnecessary critical section for SMP

Posted by GitBox <gi...@apache.org>.

masayuki2009 commented on pull request #3856:
URL: https://github.com/apache/incubator-nuttx/pull/3856#issuecomment-855199627


   The comment is incorrect, let me check again.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org