You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/15 12:16:20 UTC
[GitHub] [kafka] dengziming opened a new pull request #9442: [MINOR] optimeze unrecordedVoters method
dengziming opened a new pull request #9442:
URL: https://github.com/apache/kafka/pull/9442
Just as `grantingVoters()` and `rejectingVoters()`, `unrecordedVoters()` method be optimezed by using `votersInState(State)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9442: MINOR: optimize unrecordedVoters method
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9442:
URL: https://github.com/apache/kafka/pull/9442#issuecomment-714330436
@dengziming Thanks for your patch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on pull request #9442: [MINOR] optimize unrecordedVoters method
Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #9442:
URL: https://github.com/apache/kafka/pull/9442#issuecomment-709269033
@hachikuji , PTAL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9442: MINOR: optimize unrecordedVoters method
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9442:
URL: https://github.com/apache/kafka/pull/9442#issuecomment-712613787
@dengziming I believe those failed tests are unrelated to your PR but could you rebase it to trigger QA again ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 merged pull request #9442: MINOR: optimize unrecordedVoters method
Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #9442:
URL: https://github.com/apache/kafka/pull/9442
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org