[GitHub] [iceberg] jackye1995 commented on a change in pull request #1844: AWS: support custom credentials, region and assume role functionality

[GitBox <gi...@apache.org>]

jackye1995 commented on a change in pull request #1844:
URL: https://github.com/apache/iceberg/pull/1844#discussion_r533046018



##########
File path: aws/src/main/java/org/apache/iceberg/aws/AwsClientCredentialsFactory.java
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iceberg.aws;
+
+import java.io.Serializable;
+import org.apache.iceberg.catalog.CatalogConfigurable;
+import software.amazon.awssdk.awscore.client.builder.AwsClientBuilder;
+
+/**
+ * Interface for loading a custom factory to configure AWS credentials for different services.
+ * See {@link AssumeRoleCredentialsFactory} as an example.

Review comment:
       The `AssumeRoleCredentialsFactory` is an example for it, I can give another example with more complicated customer use case:
   
   ```java
   package com.my.team;
   
   import software.amazon.awssdk.auth.credentials.ContainerCredentialsProvider;
   import software.amazon.awssdk.awscore.client.builder.AwsClientBuilder;
   import software.amazon.awssdk.services.glue.GlueClient;
   import software.amazon.awssdk.services.glue.GlueClientBuilder;
   import software.amazon.awssdk.services.s3.S3ClientBuilder;
   import software.amazon.awssdk.services.sts.auth.StsAssumeRoleCredentialsProvider;
   import software.amazon.awssdk.services.sts.auth.StsAssumeRoleWithSamlCredentialsProvider;
   
   public class CustomCredentialsFactory implements AwsClientCredentialsFactory {
   
   
     @Override
     public void configure(AwsClientBuilder clientBuilder) {
      if (clientBuilder instanceof S3ClientBuilder) {
        clientBuilder.credentialsProvider(StsAssumeRoleWithSamlCredentialsProvider.builder()
            .refreshRequest(...)
            .build());
      } else if (clientBuilder instanceof GlueClientBuilder) {
        clientBuilder.credentialsProvider(StsAssumeRoleCredentialsProvider.builder()
            .refreshRequest(...)
            .build())
      } else {
        clientBuilder.credentialsProvider(ContainerCredentialsProvider.builder().build());
      }
     }
   }
   ```
   
   And it can be started with:
   ```
   spark-sql --jars iceberg-spark3-runtime.jar \
       --conf spark.sql.catalog.my_catalog=org.apache.iceberg.spark.SparkCatalog \
       --conf spark.sql.catalog.my_catalog.catalog-impl=org.apache.iceberg.aws.glue.GlueCatalog \
       --conf spark.sql.catalog.my_catalog.warehouse=s3://my-bucket \
       --conf spark.sql.catalog.my_catalog.client.credentials-factory=com.my.team.CustomCredentialsFactory
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org