You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by Yang Wang <da...@gmail.com> on 2022/05/26 07:47:23 UTC
[VOTE] Apache Flink Kubernetes Operator Release 1.0.0, release candidate #2
Hi everyone,
Please review and vote on the release candidate #2 for the version 1.0.0 of
Apache Flink Kubernetes Operator,
as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)
**Release Overview**
As an overview, the release consists of the following:
a) Kubernetes Operator canonical source distribution (including the
Dockerfile), to be deployed to the release repository at dist.apache.org
b) Kubernetes Operator Helm Chart to be deployed to the release repository
at dist.apache.org
c) Maven artifacts to be deployed to the Maven Central Repository
d) Docker image to be pushed to dockerhub
**Staging Areas to Review**
The staging areas containing the above mentioned artifacts are as follows,
for your review:
* All artifacts for a,b) can be found in the corresponding dev repository
at dist.apache.org [1]
* All artifacts for c) can be found at the Apache Nexus Repository [2]
* The docker image for d) is staged on github [7]
All artifacts are signed with the key
2FF2977BBBFFDF283C6FE7C6A301006F3591EE2C [3]
Other links for your review:
* JIRA release notes [4]
* source code tag "release-1.0.0-rc2" [5]
* PR to update the website Downloads page to include Kubernetes Operator
links [6]
**Vote Duration**
The voting time will run for at least 72 hours.
It is adopted by majority approval, with at least 3 PMC affirmative votes.
**Note on Verification**
You can follow the basic verification guide here[8].
Note that you don't need to verify everything yourself, but please make
note of what you have tested together with your +- vote.
Thanks,
Yang
[1]
https://dist.apache.org/repos/dist/dev/flink/flink-kubernetes-operator-1.0.0-rc2/
[2] https://repository.apache.org/content/repositories/orgapacheflink-1504/
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351500
[5]
https://github.com/apache/flink-kubernetes-operator/tree/release-1.0.0-rc2
[6] https://github.com/apache/flink-web/pull/542
[7] ghcr.io/apache/flink-kubernetes-operator:6e2b896
[8]
https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Kubernetes+Operator+Release
Re: [VOTE] Apache Flink Kubernetes Operator Release 1.0.0, release candidate #2
Posted by Yang Wang <da...@gmail.com>.
Thanks Jim for providing the information and Gyula for sharing the concerns.
I will create the release candidate #3 after we have more progress on
the FLINK-27804, whether we are sure it is resolved or we have found the
root cause.
Also I will try to make the Dockerfile could work for podman.
Best,
Yang
Gyula Fóra <gy...@gmail.com> 于2022年5月28日周六 02:37写道：
> Hi Devs!
>
> We have been performing extensive manual testing on the release.
>
> We have found some very infrequent savepoint upgrade issues with Flink 1.15
> deployments that we could not reliably reproduce so far. I have added a fix
> that hopefully eliminates the root cause (
> https://issues.apache.org/jira/browse/FLINK-27804)
> Since adding this we haven't hit the same problem again, so our confidence
> in the fix is growing :)
>
> I think it would make sense to create a new RC including this fix tomorrow,
> or whenever you have time Yang.
> We do not need to rush this release, I would prefer to take an extra 1-2
> days to eliminate these corner cases as much as possible.
>
> Cheers,
> Gyula
>
> On Fri, May 27, 2022 at 11:09 AM Jim Busche <jb...@us.ibm.com> wrote:
>
> > Hi Yang,
> >
> >
> > Oh, I’ve been using podman on Red Hat for testing:
> >
> > podman version
> >
> > Client: Podman Engine
> >
> > Version: 4.0.2
> >
> > API Version: 4.0.2
> >
> >
> > If I use Docker (version 20.10.13 for me right now) then it builds fine
> > with that COPY git line. Nice!
> >
> >
> >
> > To use podman, I need to either comment out the COPY git line, or mkdir
> > .git first.
> >
> >
> >
> > Thanks, Jim
> >
> >
> >
> >
> >
> >
>
Re: [VOTE] Apache Flink Kubernetes Operator Release 1.0.0, release candidate #2
Posted by Gyula Fóra <gy...@gmail.com>.
Hi Devs!
We have been performing extensive manual testing on the release.
We have found some very infrequent savepoint upgrade issues with Flink 1.15
deployments that we could not reliably reproduce so far. I have added a fix
that hopefully eliminates the root cause (
https://issues.apache.org/jira/browse/FLINK-27804)
Since adding this we haven't hit the same problem again, so our confidence
in the fix is growing :)
I think it would make sense to create a new RC including this fix tomorrow,
or whenever you have time Yang.
We do not need to rush this release, I would prefer to take an extra 1-2
days to eliminate these corner cases as much as possible.
Cheers,
Gyula
On Fri, May 27, 2022 at 11:09 AM Jim Busche <jb...@us.ibm.com> wrote:
> Hi Yang,
>
>
> Oh, I’ve been using podman on Red Hat for testing:
>
> podman version
>
> Client: Podman Engine
>
> Version: 4.0.2
>
> API Version: 4.0.2
>
>
> If I use Docker (version 20.10.13 for me right now) then it builds fine
> with that COPY git line. Nice!
>
>
>
> To use podman, I need to either comment out the COPY git line, or mkdir
> .git first.
>
>
>
> Thanks, Jim
>
>
>
>
>
>
RE: [VOTE] Apache Flink Kubernetes Operator Release 1.0.0, release candidate #2
Posted by Jim Busche <jb...@us.ibm.com>.
Hi Yang,
Oh, I’ve been using podman on Red Hat for testing:
podman version
Client: Podman Engine
Version: 4.0.2
API Version: 4.0.2
If I use Docker (version 20.10.13 for me right now) then it builds fine with that COPY git line. Nice!
To use podman, I need to either comment out the COPY git line, or mkdir .git first.
Thanks, Jim
Re: [VOTE] Apache Flink Kubernetes Operator Release 1.0.0, release candidate #2
Posted by Yang Wang <da...@gmail.com>.
Thanks Jim for the testing.
Could you please share the docker version you are using to build the image?
It works well for "20.10.8".
*COPY *.git ./.git*
The above copy command should ignore the .git directory if it does not
exist.
Best,
Yang
Jim Busche <jb...@us.ibm.com> 于2022年5月27日周五 02:57写道：
> Hi Yang,
>
>
> I still see the git issue when trying to build from source:
>
> [1/2] STEP 16/19: COPY *.git ./.git
>
> Error: error building at STEP "COPY *.git ./.git": checking on sources
> under "/root/FLINK/release-1.0-rc2/flink-kubernetes-operator-1.0.0": Rel:
> can't make relative to
> /root/FLINK/release-1.0-rc2/flink-kubernetes-operator-1.0.0; copier: stat:
> ["/*.git"]: no such file or directory
>
>
>
> If I remove that COPY git line, or I first make an empty .git filesystem,
> then the build proceeds ok. Not sure what all we lose in the image if the
> underlying .git items are missing.
>
>
>
> Other testing:
>
> * The helm install looks good
> * Twistlock vulnerability scan of the Debian image looks good.
> * Basic example deployed ok
>
> Thanks, Jim
>
>
>
Re: [VOTE] Apache Flink Kubernetes Operator Release 1.0.0, release candidate #2
Posted by Jim Busche <jb...@us.ibm.com>.
Hi Yang,
I still see the git issue when trying to build from source:
[1/2] STEP 16/19: COPY *.git ./.git
Error: error building at STEP "COPY *.git ./.git": checking on sources under "/root/FLINK/release-1.0-rc2/flink-kubernetes-operator-1.0.0": Rel: can't make relative to /root/FLINK/release-1.0-rc2/flink-kubernetes-operator-1.0.0; copier: stat: ["/*.git"]: no such file or directory
If I remove that COPY git line, or I first make an empty .git filesystem, then the build proceeds ok. Not sure what all we lose in the image if the underlying .git items are missing.
Other testing:
* The helm install looks good
* Twistlock vulnerability scan of the Debian image looks good.
* Basic example deployed ok
Thanks, Jim