[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #3256: Build: Move Spark version modules under spark directory

[GitBox <gi...@apache.org>]

RussellSpitzer commented on a change in pull request #3256:
URL: https://github.com/apache/iceberg/pull/3256#discussion_r726673564



##########
File path: jmh.gradle
##########
@@ -19,9 +19,9 @@
 
 def jmhProjects = []
 if (JavaVersion.current() == JavaVersion.VERSION_1_8) {
-  jmhProjects = [ project("iceberg-spark2"), project("iceberg-spark3") ]
+  jmhProjects = [ project(":iceberg-spark:iceberg-spark2"), project(":iceberg-spark:iceberg-spark3") ]

Review comment:
       I was wondering why do this with a def since I think we only need this as a local variable, 
   
   I was messing around writing new tests for ZOrdering and subbed out this code with
   
   ```groovy
   List<Project> jmhProjects = (JavaVersion.current() == JavaVersion.VERSION_1_8) ?
     [project("iceberg-spark2"), project("iceberg-spark3")] : [project("iceberg-spark3")]
   ```
   
   I think if we want to keep the version erroring we could do
   
   ```groovy
   List<Project> jmhProjects = []
   switch (JavaVersion.current()) {
     case JavaVersion.VERSION_1_8:
           jmhProjects = [project("iceberg-spark2"), project("iceberg-spark3")]
           break;
     case JavaVersion.VERSION_11:
           jmhProjects = [project("iceberg-spark3")]
           break;
     default:
       throw new GradleException("The JMH benchamrks must be run with JDK 8 or JDK 11")
   } 
   ```
   
   Anyway just a suggestion, feel free to ignore
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org