You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Ashish Jain (JIRA)" <ji...@apache.org> on 2010/01/14 09:14:54 UTC

[jira] Created: (GERONIMO-5027) Redeploy option for farming

Redeploy option for farming
---------------------------

                 Key: GERONIMO-5027
                 URL: https://issues.apache.org/jira/browse/GERONIMO-5027
             Project: Geronimo
          Issue Type: New Feature
      Security Level: public (Regular issues)
          Components: Clustering
    Affects Versions: 2.1.4, 2.2
         Environment: Windows XP g214
            Reporter: Ashish Jain
             Fix For: 2.1.5, 2.2.1


Redeploy feature for farming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-5027) Redeploy option for farming

Posted by "Ashish Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844840#action_12844840 ] 

Ashish Jain commented on GERONIMO-5027:
---------------------------------------

Hi Shawn,
I have tested the following scenarios:
1)deploy redeploy --targets <target_name> [module] [plan]
2) deploy redeploy --targets <target_name> [module]
3) deploy redeploy --targets <target_name> [module] [moduleId]

Can you advice if there are other scenarios I need to test??

I am still looking at the gshell equivalent.

Thanks
Ashish

> Redeploy option for farming
> ---------------------------
>
>                 Key: GERONIMO-5027
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5027
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.2
>         Environment: Windows XP g214
>            Reporter: Ashish Jain
>            Assignee: Ashish Jain
>             Fix For: 2.1.5, 2.2.1
>
>         Attachments: 5027_21.patch
>
>
> Redeploy feature for farming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-5027) Redeploy option for farming

Posted by "Ashish Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Jain updated GERONIMO-5027:
----------------------------------

    Attachment: 5027_21_updated.patch

Uploading a modified patch.

> Redeploy option for farming
> ---------------------------
>
>                 Key: GERONIMO-5027
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5027
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.2
>         Environment: Windows XP g214
>            Reporter: Ashish Jain
>            Assignee: Ashish Jain
>             Fix For: 2.1.5, 2.2.1
>
>         Attachments: 5027_21.patch, 5027_21_updated.patch
>
>
> Redeploy feature for farming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-5027) Redeploy option for farming

Posted by "Ashish Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Jain updated GERONIMO-5027:
----------------------------------

    Attachment: 5027_21.patch

Please verify the patch thanks.

> Redeploy option for farming
> ---------------------------
>
>                 Key: GERONIMO-5027
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5027
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.2
>         Environment: Windows XP g214
>            Reporter: Ashish Jain
>            Assignee: Ashish Jain
>             Fix For: 2.1.5, 2.2.1
>
>         Attachments: 5027_21.patch
>
>
> Redeploy feature for farming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (GERONIMO-5027) Redeploy option for farming

Posted by "Ashish Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Jain reassigned GERONIMO-5027:
-------------------------------------

    Assignee: Ashish Jain

> Redeploy option for farming
> ---------------------------
>
>                 Key: GERONIMO-5027
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5027
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.2
>         Environment: Windows XP g214
>            Reporter: Ashish Jain
>            Assignee: Ashish Jain
>             Fix For: 2.1.5, 2.2.1
>
>
> Redeploy feature for farming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (GERONIMO-5027) Redeploy option for farming

Posted by "Rex Wang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rex Wang closed GERONIMO-5027.
------------------------------


closing it

> Redeploy option for farming
> ---------------------------
>
>                 Key: GERONIMO-5027
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5027
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.2
>         Environment: Windows XP g214
>            Reporter: Ashish Jain
>            Assignee: Shawn Jiang
>             Fix For: 2.1.5, 2.2.1, 3.0
>
>         Attachments: 5027_21.patch, 5027_21_updated.patch
>
>
> Redeploy feature for farming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-5027) Redeploy option for farming

Posted by "Rex Wang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rex Wang updated GERONIMO-5027:
-------------------------------

    Patch Info: [Patch Available]

> Redeploy option for farming
> ---------------------------
>
>                 Key: GERONIMO-5027
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5027
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.2
>         Environment: Windows XP g214
>            Reporter: Ashish Jain
>            Assignee: Ashish Jain
>             Fix For: 2.1.5, 2.2.1
>
>         Attachments: 5027_21.patch
>
>
> Redeploy feature for farming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (GERONIMO-5027) Redeploy option for farming

Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shawn Jiang reassigned GERONIMO-5027:
-------------------------------------

    Assignee: Shawn Jiang  (was: Ashish Jain)

> Redeploy option for farming
> ---------------------------
>
>                 Key: GERONIMO-5027
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5027
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.2
>         Environment: Windows XP g214
>            Reporter: Ashish Jain
>            Assignee: Shawn Jiang
>             Fix For: 2.1.5, 2.2.1
>
>         Attachments: 5027_21.patch, 5027_21_updated.patch
>
>
> Redeploy feature for farming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-5027) Redeploy option for farming

Posted by "Ashish Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845725#action_12845725 ] 

Ashish Jain commented on GERONIMO-5027:
---------------------------------------

Forgot to update yesterday-"I will upload another patch for gshell equivalent".

> Redeploy option for farming
> ---------------------------
>
>                 Key: GERONIMO-5027
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5027
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.2
>         Environment: Windows XP g214
>            Reporter: Ashish Jain
>            Assignee: Ashish Jain
>             Fix For: 2.1.5, 2.2.1
>
>         Attachments: 5027_21.patch, 5027_21_updated.patch
>
>
> Redeploy feature for farming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-5027) Redeploy option for farming

Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842585#action_12842585 ] 

Shawn Jiang commented on GERONIMO-5027:
---------------------------------------

Hi Ashish,

I tried your patch but it does not work, see following two error scenarios:


1, redeploy with the application and plan:


{noformat}
R:\farm_deploy\server0\bin>deploy redeploy --targets org.apache.geronimo.configs/farming/2.1.5-SNAPSHOT/car?ServiceModule=org.apache.geronimo.configs/farming/2.1.5-SNAPSHOT/car,j2eeType=ConfigurationStore,name=MasterConfigurationStore ../..
/servlet-examples-cluster-server0.war ../../servlet-examples-cluster-plan0.xml
Using GERONIMO_HOME:   R:\farm_deploy\server0
Using GERONIMO_TMPDIR: var\temp
Using JRE_HOME:        D:\dev\JDKs\sun_jdk6\jre
    No ModuleID or TargetModuleID provided.  Attempting to guess based
    on the content of the archive.
    Unable to locate Geronimo deployment plan in archive.  Calculating
    default ModuleID from archive name.
    Attempting to use ModuleID
    'default/servlet-examples-cluster-server0_G_MASTER//'
2010-03-08 16:39:49,047 ERROR [DeployTool] Error:
org.apache.geronimo.common.DeploymentException: default/servlet-examples-cluster-server0_G_MASTER// does not appear to be a the name of a module available on the selected server. Perhaps it has already been stopped or undeployed?  If you're
 trying to specify a TargetModuleID, use the syntax TargetName|ModuleName instead. If you're not sure what's running, try the list-modules command.
        at org.apache.geronimo.deployment.plugin.ConfigIDExtractor.identifyTargetModuleIDs(ConfigIDExtractor.java:205)
        at org.apache.geronimo.deployment.cli.CommandRedeploy.guessModuleId(CommandRedeploy.java:107)
        at org.apache.geronimo.deployment.cli.CommandRedeploy.execute(CommandRedeploy.java:181)
        at org.apache.geronimo.deployment.cli.DeployTool.execute(DeployTool.java:171)
        at org.apache.geronimo.kernel.util.MainConfigurationBootstrapper.main(MainConfigurationBootstrapper.java:45)
        at org.apache.geronimo.cli.AbstractCLI.executeMain(AbstractCLI.java:67)
        at org.apache.geronimo.cli.deployer.DeployerCLI.main(DeployerCLI.java:31)

{noformat}

default/servlet-examples-cluster-server0_G_MASTER// was caculated by mistake.  It should be  samples/servlet-examples-cluster-server1_G_MASTER/2.2/war



2, redeploy with the moduleId directly:
{noformat}
R:\farm_deploy\server0\bin>deploy list-modules  org.apache.geronimo.configs/farming/2.1.5-SNAPSHOT/car?ServiceModule=org.apache.geronimo.configs/farming/2.1.5-SNAPSHOT/car,j2eeType=ConfigurationStore,name=MasterConfigurationStore
Using GERONIMO_HOME:   R:\farm_deploy\server0
Using GERONIMO_TMPDIR: var\temp
Using JRE_HOME:        D:\dev\JDKs\sun_jdk6\jre
Found 1 module
  + samples/servlet-examples-cluster-server1_G_MASTER/2.2/war


R:\farm_deploy\server0\bin>deploy redeploy --targets org.apache.geronimo.configs/farming/2.1.5-SNAPSHOT/car?ServiceModule=org.apache.geronimo.configs/farming/2.1.5-SNAPSHOT/car,j2eeType=ConfigurationStore,name=MasterConfigurationStore sampl
es/servlet-examples-cluster-server1_G_MASTER/2.2/war
Using GERONIMO_HOME:   R:\farm_deploy\server0
Using GERONIMO_TMPDIR: var\temp
Using JRE_HOME:        D:\dev\JDKs\sun_jdk6\jre
2010-03-08 16:36:56,937 ERROR [DeployTool] Error:
org.apache.geronimo.deployment.cli.DeploymentSyntaxException: Module or plan file does not exist: R:\farm_deploy\server0\bin\samples\servlet-examples-cluster-server1_G_MASTER\2.2\war
        at org.apache.geronimo.deployment.cli.CommandRedeploy.checkFirstArguement(CommandRedeploy.java:53)
        at org.apache.geronimo.deployment.cli.CommandRedeploy.execute(CommandRedeploy.java:150)
        at org.apache.geronimo.deployment.cli.DeployTool.execute(DeployTool.java:171)
        at org.apache.geronimo.kernel.util.MainConfigurationBootstrapper.main(MainConfigurationBootstrapper.java:45)
        at org.apache.geronimo.cli.AbstractCLI.executeMain(AbstractCLI.java:67)
        at org.apache.geronimo.cli.deployer.DeployerCLI.main(DeployerCLI.java:31)
{noformat}



-------------------------------------------------------------------------------------------------------------------------------------------------------------------

The results above indicate the patch you upload need to rework.    I also found two obvious possible problems in the patch:


1,  if(args.length>=3 && args[0].equalsIgnoreCase("--targets")) //case of cluster redeployment
+            {

The lines above hard coded the --targets as the first args, If the user put the --targets in different sequence, the command will fail.


2, The gshell equivalence does not get updated to pull in the new command options so that your new farm redeploy will definitely not work in gshell.
The corresponding file should be 
framework\modules\geronimo-commands\src\main\groovy\org\apache\geronimo\commands\DeployModuleCommand.groovy



> Redeploy option for farming
> ---------------------------
>
>                 Key: GERONIMO-5027
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5027
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.2
>         Environment: Windows XP g214
>            Reporter: Ashish Jain
>            Assignee: Ashish Jain
>             Fix For: 2.1.5, 2.2.1
>
>         Attachments: 5027_21.patch
>
>
> Redeploy feature for farming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-5027) Redeploy option for farming

Posted by "Rex Wang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847201#action_12847201 ] 

Rex Wang commented on GERONIMO-5027:
------------------------------------

Please link the new jira to this so that we can have a track. thanks

> Redeploy option for farming
> ---------------------------
>
>                 Key: GERONIMO-5027
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5027
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.2
>         Environment: Windows XP g214
>            Reporter: Ashish Jain
>            Assignee: Shawn Jiang
>             Fix For: 2.1.5, 2.2.1, 3.0
>
>         Attachments: 5027_21.patch, 5027_21_updated.patch
>
>
> Redeploy feature for farming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-5027) Redeploy option for farming

Posted by "Ashish Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846827#action_12846827 ] 

Ashish Jain commented on GERONIMO-5027:
---------------------------------------

Thanks Shawn I will open a new JIRA for GShell equivalence.

> Redeploy option for farming
> ---------------------------
>
>                 Key: GERONIMO-5027
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5027
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.2
>         Environment: Windows XP g214
>            Reporter: Ashish Jain
>            Assignee: Shawn Jiang
>             Fix For: 2.1.5, 2.2.1, 3.0
>
>         Attachments: 5027_21.patch, 5027_21_updated.patch
>
>
> Redeploy feature for farming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-5027) Redeploy option for farming

Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845751#action_12845751 ] 

Shawn Jiang commented on GERONIMO-5027:
---------------------------------------

Thanks, I'll hold on until the gshell patch is ready.  

> Redeploy option for farming
> ---------------------------
>
>                 Key: GERONIMO-5027
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5027
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.2
>         Environment: Windows XP g214
>            Reporter: Ashish Jain
>            Assignee: Shawn Jiang
>             Fix For: 2.1.5, 2.2.1
>
>         Attachments: 5027_21.patch, 5027_21_updated.patch
>
>
> Redeploy feature for farming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (GERONIMO-5027) Redeploy option for farming

Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shawn Jiang resolved GERONIMO-5027.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 3.0

Committed the patch to 21, 22, trunk with Revsion 924620,924622,924625

Thanks Ashish for the patch !  Please open another JIRA to track the gshell equivalence.  

> Redeploy option for farming
> ---------------------------
>
>                 Key: GERONIMO-5027
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5027
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.2
>         Environment: Windows XP g214
>            Reporter: Ashish Jain
>            Assignee: Shawn Jiang
>             Fix For: 2.1.5, 2.2.1, 3.0
>
>         Attachments: 5027_21.patch, 5027_21_updated.patch
>
>
> Redeploy feature for farming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-5027) Redeploy option for farming

Posted by "Ashish Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800641#action_12800641 ] 

Ashish Jain commented on GERONIMO-5027:
---------------------------------------

Here is what I have understood

Redeploy in geronimo is handled by a set of STOP, UNLOAD, UNINSTALL, INSTALL. LOAD, START operations. In case of farming as there are set of nodes we will have to obtain the JMX info of each of the nodes so as to get a kernel for each of the nodes. Any of the deploy commands is executed by obtaning the meta data and than calling up
the execute for the meta data. In case of farming install and uninstall are taken care of by ConfigurationStore.install/uninstall.

In case of redeploy configuration manager is being used which is obtained through COnfigurationUtil.getConfigurationManager(kernel).

There were various ways I have tried to achieve this for farming

1) To get the meta data for deploy and undeploy in redeploy, which is not possible due to private constructors.
2) Extend the DeployTool to take up this case but this does not seem to be correct to be specific for one funtionality.
3) Get the NodeInfo's in RedeployCommand and with some modifications to artifact call up a series of STOP, UNLOAD, UNINSTALL, INSTALL. LOAD, START operations.

There can be many other approaches which could be used of which I am not aware of..

Comments please?? 

> Redeploy option for farming
> ---------------------------
>
>                 Key: GERONIMO-5027
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5027
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.2
>         Environment: Windows XP g214
>            Reporter: Ashish Jain
>             Fix For: 2.1.5, 2.2.1
>
>
> Redeploy feature for farming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-5027) Redeploy option for farming

Posted by "Ashish Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830084#action_12830084 ] 

Ashish Jain commented on GERONIMO-5027:
---------------------------------------

To use this feature. Run the following command
deploy.bat --user system --password manager redeploy --targets  org.apache.geronimo.configs/farming/2.1.4/car?ServiceModule=org.apache.geronimo.configs/farming/2.1.4/car,j2eeType=ConfigurationStore,name=MasterConfigurationStore <application_file>

> Redeploy option for farming
> ---------------------------
>
>                 Key: GERONIMO-5027
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5027
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.2
>         Environment: Windows XP g214
>            Reporter: Ashish Jain
>            Assignee: Ashish Jain
>             Fix For: 2.1.5, 2.2.1
>
>         Attachments: 5027_21.patch
>
>
> Redeploy feature for farming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-5027) Redeploy option for farming

Posted by "Ashish Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843022#action_12843022 ] 

Ashish Jain commented on GERONIMO-5027:
---------------------------------------

Hi Shawn,

Thanks for all your comments and improvements.

I have fixed 1). I am not sure how 2) works because I do not see any app or plan which you are trying to redeploy. 

The results above indicate the patch you upload need to rework. I also found two obvious possible problems in the patch:

1, if(args.length>=3 && args[0].equalsIgnoreCase("--targets")) //case of cluster redeployment
+ {

The lines above hard coded the --targets as the first args, If the user put the --targets in different sequence, the command will fail.

"""""I am not sure if user can specify --targets in any order because I see ""commandLine = parser.parse(options, args, true); in DistributeCommandArgsImpl gives different results if u specify 
--target in any order.""""""""

Thanks
Ashish


I am still looking into it

> Redeploy option for farming
> ---------------------------
>
>                 Key: GERONIMO-5027
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5027
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.2
>         Environment: Windows XP g214
>            Reporter: Ashish Jain
>            Assignee: Ashish Jain
>             Fix For: 2.1.5, 2.2.1
>
>         Attachments: 5027_21.patch
>
>
> Redeploy feature for farming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-5027) Redeploy option for farming

Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844879#action_12844879 ] 

Shawn Jiang commented on GERONIMO-5027:
---------------------------------------

The scenarios are enough for this function.  I'm looking forward to your updated patch.

> Redeploy option for farming
> ---------------------------
>
>                 Key: GERONIMO-5027
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5027
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.2
>         Environment: Windows XP g214
>            Reporter: Ashish Jain
>            Assignee: Ashish Jain
>             Fix For: 2.1.5, 2.2.1
>
>         Attachments: 5027_21.patch
>
>
> Redeploy feature for farming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-5027) Redeploy option for farming

Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843396#action_12843396 ] 

Shawn Jiang commented on GERONIMO-5027:
---------------------------------------

1,  the --targets sequence problem, I think we need to document it somewhere.

2,  note the message when redeploy with the module-id, seems the redeploy are trying to find the module under GERONIMO_HOME\bin instead of GERONIMO_HOME\repository
{noformat}
org.apache.geronimo.deployment.cli.DeploymentSyntaxException: Module or plan file does not exist: R:\farm_deploy\server0\bin\samples\servlet-examples-cluster-server1_G_MASTE
{noformat}

3, The gshell equivalence is still needed.


Thanks.

> Redeploy option for farming
> ---------------------------
>
>                 Key: GERONIMO-5027
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5027
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.2
>         Environment: Windows XP g214
>            Reporter: Ashish Jain
>            Assignee: Ashish Jain
>             Fix For: 2.1.5, 2.2.1
>
>         Attachments: 5027_21.patch
>
>
> Redeploy feature for farming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.