You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Flink Jira Bot (Jira)" <ji...@apache.org> on 2021/06/08 10:46:01 UTC

[jira] [Updated] (FLINK-12182) AggregateProjectMergeRule can not handle LogicalWindowAggregate

     [ https://issues.apache.org/jira/browse/FLINK-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Flink Jira Bot updated FLINK-12182:
-----------------------------------
    Labels: auto-unassigned stale-major  (was: auto-unassigned)

I am the [Flink Jira Bot|https://github.com/apache/flink-jira-bot/] and I help the community manage its development. I see this issues has been marked as Major but is unassigned and neither itself nor its Sub-Tasks have been updated for 30 days. I have gone ahead and added a "stale-major" to the issue". If this ticket is a Major, please either assign yourself or give an update. Afterwards, please remove the label or in 7 days the issue will be deprioritized.


> AggregateProjectMergeRule can not handle LogicalWindowAggregate
> ---------------------------------------------------------------
>
>                 Key: FLINK-12182
>                 URL: https://issues.apache.org/jira/browse/FLINK-12182
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / API
>            Reporter: Hequn Cheng
>            Priority: Major
>              Labels: auto-unassigned, stale-major
>
> Currently, we add the AggregateProjectMergeRule.INSTANCE in logical rule sets and use it to remove project for aggregates. However, there are some bugs when this rule be applied for the LogicalWindowAggregate.
> When the project was removed, the input field names are changed, so the rule has to update all fields in the Aggregate, while the field name in LogicalWindow in LogicalWindowAggregate has not taken into consideration in AggregateProjectMergeRule, as it is a rule in Calcite.
> This problem also lies in other Aggregate rules such as FilterAggregateTransposeRule and AggregateProjectPullUpConstantsRule, etc.
> As a quick fix, I think we can change
> {code:java}
> AggregateProjectMergeRule.INSTANCE,
> {code}
> to
> {code:java}
>     new AggregateProjectMergeRule(
>       classOf[LogicalAggregate], classOf[Project], RelFactories.LOGICAL_BUILDER),
> {code}
> Of course, we need a complete solution for the LogicalWindowAggregate(use LogicalAggregate to express LogicalWindowAggregate), but not in this jira.
> Any suggestions are welcomed!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)