You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Grégory Joseph <gr...@gmail.com> on 2011/08/02 14:47:48 UTC
Re: Upgrading maven-checkstyle-plugin checkstyle version support
Stephen,
That won't work, because checkstyle changed its groupId from
"checkstyle" to "com.puppycrawl.tools" since 5.2, so afaik we're stuck
until m-checkstyle-p 2.7 is released (unless you can exclude "top
level" dependencies from a plugin, but I wouldn't know how).
Olivier Lamy mentioned in another thread on the user list that he
might start working on this beginning of this month, so... fingers
crossed !
Cheers,
-g
On 29 July 2011 09:10, Stephen Connolly <st...@gmail.com> wrote:
>
> You could just try with checkstyle 5.3.
>
> there is the ability to override the dependencies of a plugin
>
> <project>
> <build>
> <plugins>
> <plugin>
> <artifactId>maven-checkstyle-plugin</artifactId>
> <dependencies>
> ... insert the newer version of checkstyle (not the plugin) here
> </dependencies>
> </plugin>
> </plugins>
> </build>
> </project>
>
> If the only change is a version bumb, then you can achieve that by
> overriding with a bumped version in your pom...
>
> No new release needed unless the newer version has changed its API
>
> -Stephen
>
> On 28 July 2011 15:57, Chris Whelan <ch...@gmail.com> wrote:
> > Hi all,
> >
> > I'm looking to use the maven-checkstyle-plugin with checkstyle 5.3, but it
> > only supports 5.0 as of the 2.6 release of the plugin.
> >
> > Looking at trunk it seems to already have been upgraded to 5.3 but there
> > haven't been commits for a couple of months.
> >
> > I'm using a few rules which are not available on 5.0 so can't currently make
> > use of this plug-in. I have a few queries:
> >
> > 1. What are the plans for releasing v2.7 of the plugin? Is there any more
> > work outstanding for checkstyle 5.3/5.4 support? I'd be happy to help with
> > any remaining tasks to get this pushed out the door as it would be a useful
> > upgrade for me.
> >
> > 2. I've done a quick diff of the 1.6 tag against trunk and looking at the
> > changes, the only change related to the checkstyle 5.3 upgrade seems to be
> > bumping the version number of the dependency in the plugin's pom file. Is
> > this all that's needed to make the new plugins from checkstyle 5.3
> > executable via the plugin?
> >
> > 3. Given that new checkstyle releases pop up every now and again and are
> > likely to include new plug-ins but not necessarily break the API used by
> > maven-checkstyle-plugin, is there another mechanism that could be used to
> > make the upgrade easier? I'm thinking something like a plugin configuration
> > setting <checkstyle.version> which could be used to specify the checkstyle
> > dependency used by the plug-in. That way it would be possible to use the
> > plugin with future minor releases of checkstyle without having to do a new
> > release of the plug-in itself?
> >
> > I might be oversimplifying things, I'm not sure if additional configuration
> > or glue code is needed to make the new checkstyle rules available through
> > the plug-in when upgrading to 5.3 and beyond.
> >
> > Obviously this would break if checkstyle changed their API but the benefits
> > could well be worth it and the value could easily be defaulted.
> >
> > I'd be happy to work on this and submit a patch if someone can give me an
> > initial pointer to let me know if they think it would be possible.
> >
> > Cheers,
> > Chris
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Upgrading maven-checkstyle-plugin checkstyle version support
Posted by Olivier Lamy <ol...@apache.org>.
Hello,
FYI the trunk has been upgraded to use checkstyle 5.4 .
I have just applied the patch for
https://jira.codehaus.org/browse/MCHECKSTYLE-163 and deployed a
snapshot.
If nobody complains I will start release process early next week.
Thanks,
--
Olivier Lamy
Talend : http://talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy
Le 2 août 2011 14:47, Grégory Joseph <gr...@gmail.com> a écrit :
> Stephen,
>
> That won't work, because checkstyle changed its groupId from
> "checkstyle" to "com.puppycrawl.tools" since 5.2, so afaik we're stuck
> until m-checkstyle-p 2.7 is released (unless you can exclude "top
> level" dependencies from a plugin, but I wouldn't know how).
>
> Olivier Lamy mentioned in another thread on the user list that he
> might start working on this beginning of this month, so... fingers
> crossed !
>
> Cheers,
>
> -g
>
> On 29 July 2011 09:10, Stephen Connolly <st...@gmail.com> wrote:
>>
>> You could just try with checkstyle 5.3.
>>
>> there is the ability to override the dependencies of a plugin
>>
>> <project>
>> <build>
>> <plugins>
>> <plugin>
>> <artifactId>maven-checkstyle-plugin</artifactId>
>> <dependencies>
>> ... insert the newer version of checkstyle (not the plugin) here
>> </dependencies>
>> </plugin>
>> </plugins>
>> </build>
>> </project>
>>
>> If the only change is a version bumb, then you can achieve that by
>> overriding with a bumped version in your pom...
>>
>> No new release needed unless the newer version has changed its API
>>
>> -Stephen
>>
>> On 28 July 2011 15:57, Chris Whelan <ch...@gmail.com> wrote:
>> > Hi all,
>> >
>> > I'm looking to use the maven-checkstyle-plugin with checkstyle 5.3, but it
>> > only supports 5.0 as of the 2.6 release of the plugin.
>> >
>> > Looking at trunk it seems to already have been upgraded to 5.3 but there
>> > haven't been commits for a couple of months.
>> >
>> > I'm using a few rules which are not available on 5.0 so can't currently make
>> > use of this plug-in. I have a few queries:
>> >
>> > 1. What are the plans for releasing v2.7 of the plugin? Is there any more
>> > work outstanding for checkstyle 5.3/5.4 support? I'd be happy to help with
>> > any remaining tasks to get this pushed out the door as it would be a useful
>> > upgrade for me.
>> >
>> > 2. I've done a quick diff of the 1.6 tag against trunk and looking at the
>> > changes, the only change related to the checkstyle 5.3 upgrade seems to be
>> > bumping the version number of the dependency in the plugin's pom file. Is
>> > this all that's needed to make the new plugins from checkstyle 5.3
>> > executable via the plugin?
>> >
>> > 3. Given that new checkstyle releases pop up every now and again and are
>> > likely to include new plug-ins but not necessarily break the API used by
>> > maven-checkstyle-plugin, is there another mechanism that could be used to
>> > make the upgrade easier? I'm thinking something like a plugin configuration
>> > setting <checkstyle.version> which could be used to specify the checkstyle
>> > dependency used by the plug-in. That way it would be possible to use the
>> > plugin with future minor releases of checkstyle without having to do a new
>> > release of the plug-in itself?
>> >
>> > I might be oversimplifying things, I'm not sure if additional configuration
>> > or glue code is needed to make the new checkstyle rules available through
>> > the plug-in when upgrading to 5.3 and beyond.
>> >
>> > Obviously this would break if checkstyle changed their API but the benefits
>> > could well be worth it and the value could easily be defaulted.
>> >
>> > I'd be happy to work on this and submit a patch if someone can give me an
>> > initial pointer to let me know if they think it would be possible.
>> >
>> > Cheers,
>> > Chris
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org