You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/19 18:52:25 UTC
[GitHub] [spark] kiszk commented on a change in pull request #25022:
[SPARK-24695][SQL] Move `CalendarInterval` to org.apache.spark.unsafe.types
package
kiszk commented on a change in pull request #25022: [SPARK-24695][SQL] Move `CalendarInterval` to org.apache.spark.unsafe.types package
URL: https://github.com/apache/spark/pull/25022#discussion_r305483682
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/LeftSemiAntiJoinPushDownSuite.scala
##########
@@ -24,8 +24,8 @@ import org.apache.spark.sql.catalyst.expressions._
import org.apache.spark.sql.catalyst.plans._
import org.apache.spark.sql.catalyst.plans.logical._
import org.apache.spark.sql.catalyst.rules._
+import org.apache.spark.sql.types.CalendarInterval
Review comment:
nit: Can we merge lines 27 and 28 into one line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org