[iceberg] branch master updated: Build: Enforce logging conventions with errorprone (#5528)

[fo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

fokko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iceberg.git


The following commit(s) were added to refs/heads/master by this push:
     new f2267242b3 Build: Enforce logging conventions with errorprone (#5528)
f2267242b3 is described below

commit f2267242b318cef3f7ffdca72a1790f1a42fbff2
Author: Christopher Lambert <xn...@gmx.de>
AuthorDate: Mon Sep 5 19:38:12 2022 +0200

    Build: Enforce logging conventions with errorprone (#5528)
    
    These errorprone checks are just warnings by default:
    https://github.com/palantir/gradle-baseline/blob/4.0.0/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/Slf4jThrowable.java#L41
    https://github.com/palantir/gradle-baseline/blob/4.0.0/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/LoggerEnclosingClass.java#L41
    https://github.com/palantir/gradle-baseline/blob/4.0.0/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/PreferStaticLoggers.java#L43
    
    Since the codebase has no violations we should increase the severity to
    ERROR and enforce these conventions automatically going forward.
---
 baseline.gradle | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/baseline.gradle b/baseline.gradle
index cf32b258fc..6560b69937 100644
--- a/baseline.gradle
+++ b/baseline.gradle
@@ -66,6 +66,10 @@ subprojects {
           '-Xep:PreferSafeLoggableExceptions:OFF',
           '-Xep:Slf4jLogsafeArgs:OFF',
           '-Xep:RawTypes:OFF',
+          // enforce logging conventions
+          '-Xep:LoggerEnclosingClass:ERROR',
+          '-Xep:PreferStaticLoggers:ERROR',
+          '-Xep:Slf4jThrowable:ERROR',
           // subclasses are not equal
           '-Xep:EqualsGetClass:OFF',
           // prefer method references over lambdas