You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/10/02 06:57:34 UTC
[kudu-CR] KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16537
Change subject: KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
......................................................................
KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
This patch adds more consistency into the TxnStatusManager's behavior
during the time interval between the following events:
* The state of the leader replica of a transaction status tablet
changes from BOOTSTRAPPING to RUNNING (see TabletReplica::Start()
for details).
* TxnStatusManager's runtime structures are populated with the
information loaded from the tablet
(i.e. TxnStatusManager::LoadFromTablet() successfully completes).
Before this patch, relevant methods of the TxnStatusManager class could
behave inconsistently within the mentioned interval. With this patch,
those methods return Status::ServiceUnavailable() and do not exhibit any
inconsistent behavior.
This patch also adds a new test scenario to cover the new behavior.
This is a follow-up to efd8c4f165460b7fa337b8ebd1856b10bc274311.
Change-Id: Ia95f821d87145aff6587c017a425e205bdcb8b2b
---
M src/kudu/transactions/txn_status_manager-test.cc
M src/kudu/transactions/txn_status_manager.cc
M src/kudu/transactions/txn_status_manager.h
3 files changed, 119 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/16537/1
--
To view, visit http://gerrit.cloudera.org:8080/16537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia95f821d87145aff6587c017a425e205bdcb8b2b
Gerrit-Change-Number: 16537
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16537
to look at the new patch set (#3).
Change subject: KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
......................................................................
KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
This patch adds more consistency into the TxnStatusManager's behavior
during the time interval between the following events:
* The state of the leader replica of a transaction status tablet
changes from BOOTSTRAPPING to RUNNING (see TabletReplica::Start()
for details).
* TxnStatusManager's runtime structures are populated with the
information loaded from the tablet
(i.e. TxnStatusManager::LoadFromTablet() successfully completes).
Before this patch, relevant methods of the TxnStatusManager class could
behave inconsistently within the mentioned interval. With this patch,
those methods return Status::ServiceUnavailable() and do not exhibit any
inconsistent behavior.
This patch also adds a new test scenario to cover the new behavior.
This is a follow-up to efd8c4f165460b7fa337b8ebd1856b10bc274311.
Change-Id: Ia95f821d87145aff6587c017a425e205bdcb8b2b
---
M src/kudu/transactions/txn_status_manager-test.cc
M src/kudu/transactions/txn_status_manager.cc
M src/kudu/transactions/txn_status_manager.h
3 files changed, 108 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/16537/3
--
To view, visit http://gerrit.cloudera.org:8080/16537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia95f821d87145aff6587c017a425e205bdcb8b2b
Gerrit-Change-Number: 16537
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16537 )
Change subject: KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
......................................................................
Patch Set 4: Code-Review+2
LGTM, although the approach of ensure the tablet metadata is loaded may change with the TxnStatusManager leadership calls only patch I am working on.
--
To view, visit http://gerrit.cloudera.org:8080/16537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia95f821d87145aff6587c017a425e205bdcb8b2b
Gerrit-Change-Number: 16537
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 06 Oct 2020 19:45:53 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16537 )
Change subject: KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia95f821d87145aff6587c017a425e205bdcb8b2b
Gerrit-Change-Number: 16537
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 02 Oct 2020 17:47:20 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16537
to look at the new patch set (#2).
Change subject: KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
......................................................................
KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
This patch adds more consistency into the TxnStatusManager's behavior
during the time interval between the following events:
* The state of the leader replica of a transaction status tablet
changes from BOOTSTRAPPING to RUNNING (see TabletReplica::Start()
for details).
* TxnStatusManager's runtime structures are populated with the
information loaded from the tablet
(i.e. TxnStatusManager::LoadFromTablet() successfully completes).
Before this patch, relevant methods of the TxnStatusManager class could
behave inconsistently within the mentioned interval. With this patch,
those methods return Status::ServiceUnavailable() and do not exhibit any
inconsistent behavior.
This patch also adds a new test scenario to cover the new behavior.
This is a follow-up to efd8c4f165460b7fa337b8ebd1856b10bc274311.
Change-Id: Ia95f821d87145aff6587c017a425e205bdcb8b2b
---
M src/kudu/transactions/txn_status_manager-test.cc
M src/kudu/transactions/txn_status_manager.cc
M src/kudu/transactions/txn_status_manager.h
3 files changed, 109 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/16537/2
--
To view, visit http://gerrit.cloudera.org:8080/16537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia95f821d87145aff6587c017a425e205bdcb8b2b
Gerrit-Change-Number: 16537
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16537
to look at the new patch set (#6).
Change subject: KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
......................................................................
KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
This patch adds more consistency into the TxnStatusManager's behavior
during the time interval between the following events:
* The state of the leader replica of a transaction status tablet
changes from BOOTSTRAPPING to RUNNING (see TabletReplica::Start()
for details).
* TxnStatusManager's runtime structures are populated with the
information loaded from the tablet
(i.e. TxnStatusManager::LoadFromTablet() successfully completes).
Before this patch, relevant methods of the TxnStatusManager class could
behave inconsistently within the mentioned interval. With this patch,
those methods return Status::ServiceUnavailable() and do not exhibit any
inconsistent behavior.
This patch also adds a new test scenario to cover the new behavior.
This is a follow-up to efd8c4f165460b7fa337b8ebd1856b10bc274311.
Change-Id: Ia95f821d87145aff6587c017a425e205bdcb8b2b
---
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/transactions/txn_status_manager-test.cc
M src/kudu/transactions/txn_status_manager.cc
M src/kudu/transactions/txn_status_manager.h
4 files changed, 139 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/16537/6
--
To view, visit http://gerrit.cloudera.org:8080/16537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia95f821d87145aff6587c017a425e205bdcb8b2b
Gerrit-Change-Number: 16537
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16537 )
Change subject: KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
......................................................................
Patch Set 6: Code-Review+2
Carrying over Hao's +2 from PS4.
--
To view, visit http://gerrit.cloudera.org:8080/16537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia95f821d87145aff6587c017a425e205bdcb8b2b
Gerrit-Change-Number: 16537
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 07 Oct 2020 05:06:30 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16537 )
Change subject: KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
......................................................................
KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
This patch adds more consistency into the TxnStatusManager's behavior
during the time interval between the following events:
* The state of the leader replica of a transaction status tablet
changes from BOOTSTRAPPING to RUNNING (see TabletReplica::Start()
for details).
* TxnStatusManager's runtime structures are populated with the
information loaded from the tablet
(i.e. TxnStatusManager::LoadFromTablet() successfully completes).
Before this patch, relevant methods of the TxnStatusManager class could
behave inconsistently within the mentioned interval. With this patch,
those methods return Status::ServiceUnavailable() and do not exhibit any
inconsistent behavior.
This patch also adds a new test scenario to cover the new behavior.
This is a follow-up to efd8c4f165460b7fa337b8ebd1856b10bc274311.
Change-Id: Ia95f821d87145aff6587c017a425e205bdcb8b2b
Reviewed-on: http://gerrit.cloudera.org:8080/16537
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/transactions/txn_status_manager-test.cc
M src/kudu/transactions/txn_status_manager.cc
M src/kudu/transactions/txn_status_manager.h
4 files changed, 139 insertions(+), 12 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia95f821d87145aff6587c017a425e205bdcb8b2b
Gerrit-Change-Number: 16537
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16537 )
Change subject: KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
......................................................................
Patch Set 3:
Adding Hao as a reviewer, as she's working on reloading the tablet upon leadership change, and either is doing something similar or will need to.
--
To view, visit http://gerrit.cloudera.org:8080/16537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia95f821d87145aff6587c017a425e205bdcb8b2b
Gerrit-Change-Number: 16537
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 02 Oct 2020 17:42:46 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16537
to look at the new patch set (#4).
Change subject: KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
......................................................................
KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
This patch adds more consistency into the TxnStatusManager's behavior
during the time interval between the following events:
* The state of the leader replica of a transaction status tablet
changes from BOOTSTRAPPING to RUNNING (see TabletReplica::Start()
for details).
* TxnStatusManager's runtime structures are populated with the
information loaded from the tablet
(i.e. TxnStatusManager::LoadFromTablet() successfully completes).
Before this patch, relevant methods of the TxnStatusManager class could
behave inconsistently within the mentioned interval. With this patch,
those methods return Status::ServiceUnavailable() and do not exhibit any
inconsistent behavior.
This patch also adds a new test scenario to cover the new behavior.
This is a follow-up to efd8c4f165460b7fa337b8ebd1856b10bc274311.
Change-Id: Ia95f821d87145aff6587c017a425e205bdcb8b2b
---
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/transactions/txn_status_manager-test.cc
M src/kudu/transactions/txn_status_manager.cc
M src/kudu/transactions/txn_status_manager.h
4 files changed, 139 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/16537/4
--
To view, visit http://gerrit.cloudera.org:8080/16537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia95f821d87145aff6587c017a425e205bdcb8b2b
Gerrit-Change-Number: 16537
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16537 )
Change subject: KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
......................................................................
Patch Set 4:
> LGTM, although the approach of ensure the tablet metadata is loaded
> may change with the TxnStatusManager leadership calls only patch I
> am working on.
Thank you for the review! Yes, I guess this should change, and I hope there should not be too many code-wise conflicts.
--
To view, visit http://gerrit.cloudera.org:8080/16537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia95f821d87145aff6587c017a425e205bdcb8b2b
Gerrit-Change-Number: 16537
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 06 Oct 2020 19:57:47 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16537
to look at the new patch set (#5).
Change subject: KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
......................................................................
KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
This patch adds more consistency into the TxnStatusManager's behavior
during the time interval between the following events:
* The state of the leader replica of a transaction status tablet
changes from BOOTSTRAPPING to RUNNING (see TabletReplica::Start()
for details).
* TxnStatusManager's runtime structures are populated with the
information loaded from the tablet
(i.e. TxnStatusManager::LoadFromTablet() successfully completes).
Before this patch, relevant methods of the TxnStatusManager class could
behave inconsistently within the mentioned interval. With this patch,
those methods return Status::ServiceUnavailable() and do not exhibit any
inconsistent behavior.
This patch also adds a new test scenario to cover the new behavior.
This is a follow-up to efd8c4f165460b7fa337b8ebd1856b10bc274311.
Change-Id: Ia95f821d87145aff6587c017a425e205bdcb8b2b
---
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/transactions/txn_status_manager-test.cc
M src/kudu/transactions/txn_status_manager.cc
M src/kudu/transactions/txn_status_manager.h
4 files changed, 134 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/16537/5
--
To view, visit http://gerrit.cloudera.org:8080/16537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia95f821d87145aff6587c017a425e205bdcb8b2b
Gerrit-Change-Number: 16537
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16537 )
Change subject: KUDU-2612 p2 (c): small fix on TxnStatusManager's behavior
......................................................................
Patch Set 4: Code-Review+1
+1ing to give Hao a chance to review. Overall it LGTM, though I expect the approach may change based on the work she is doing.
--
To view, visit http://gerrit.cloudera.org:8080/16537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia95f821d87145aff6587c017a425e205bdcb8b2b
Gerrit-Change-Number: 16537
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 03 Oct 2020 01:43:35 +0000
Gerrit-HasComments: No