You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "vadym-serdiuk (via GitHub)" <gi...@apache.org> on 2023/12/20 15:07:47 UTC
[PR] refactor!: add possibility to deploy under the URI prefix [superset]
vadym-serdiuk opened a new pull request, #26320:
URL: https://github.com/apache/superset/pull/26320
#26319 26319
Refactoring of the redirects and url generation on the frontend and backend
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor!: add possibility to deploy under the URI prefix [superset]
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #26320:
URL: https://github.com/apache/superset/pull/26320#issuecomment-2826322431
We just merged a PR that should pretty much cover this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor!: add possibility to deploy under the URI prefix [superset]
Posted by "nachogrj (via GitHub)" <gi...@apache.org>.
nachogrj commented on code in PR #26320:
URL: https://github.com/apache/superset/pull/26320#discussion_r1738214626
##########
superset/templates/superset/basic.html:
##########
@@ -60,7 +60,7 @@
{% endif %}
{% endblock %}
-
+ <script>window.__SUPERSET_DEPLOYMENT_PREFIX__ = "{{ assets_prefix }}";</script>
Review Comment:
As I understand `assets_prefix `is initialized in "/superset/extensions/__init__.py" using the `STATIC_ASSETS_PREFIX `configuration variable, but i cannot see how and where `ASSET_BASE_URL` (Dockerfile) is assigned to be used after in the `withPrefix()` function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor!: add possibility to deploy under the URI prefix [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #26320:
URL: https://github.com/apache/superset/pull/26320#issuecomment-1874357768
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/26320?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `44 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`aa3c3c5`)](https://app.codecov.io/gh/apache/superset/commit/aa3c3c5aaa0d9fa1769ca310c9e944e86695d7db?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 69.18% compared to head [(`a707aad`)](https://app.codecov.io/gh/apache/superset/pull/26320?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 58.95%.
> Report is 30 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/superset/pull/26320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [superset/views/core.py](https://app.codecov.io/gh/apache/superset/pull/26320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | 12.50% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/26320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset/views/database/views.py](https://app.codecov.io/gh/apache/superset/pull/26320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | 9.09% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/26320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset/models/slice.py](https://app.codecov.io/gh/apache/superset/pull/26320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | 14.28% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/26320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset/connectors/sqla/models.py](https://app.codecov.io/gh/apache/superset/pull/26320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/26320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset/models/dashboard.py](https://app.codecov.io/gh/apache/superset/pull/26320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/26320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset/views/dashboard/views.py](https://app.codecov.io/gh/apache/superset/pull/26320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/26320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset/views/redirects.py](https://app.codecov.io/gh/apache/superset/pull/26320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdmlld3MvcmVkaXJlY3RzLnB5) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/26320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset/connectors/sqla/views.py](https://app.codecov.io/gh/apache/superset/pull/26320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/26320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset/dashboards/permalink/api.py](https://app.codecov.io/gh/apache/superset/pull/26320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9wZXJtYWxpbmsvYXBpLnB5) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/26320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset/explore/permalink/api.py](https://app.codecov.io/gh/apache/superset/pull/26320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZXhwbG9yZS9wZXJtYWxpbmsvYXBpLnB5) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/26320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [3 more](https://app.codecov.io/gh/apache/superset/pull/26320?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #26320 +/- ##
===========================================
- Coverage 69.18% 58.95% -10.24%
===========================================
Files 1946 1946
Lines 75969 75930 -39
Branches 8469 8465 -4
===========================================
- Hits 52560 44765 -7795
- Misses 21223 28980 +7757
+ Partials 2186 2185 -1
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/26320/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/26320/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/26320/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/26320/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/26320/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.65% <30.15%> (+0.02%)` | :arrow_up: |
| [python](https://app.codecov.io/gh/apache/superset/pull/26320/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `61.56% <30.15%> (-21.31%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/26320/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/26320/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.81% <28.57%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/26320?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor!: add possibility to deploy under the URI prefix [superset]
Posted by "vadym-serdiuk (via GitHub)" <gi...@apache.org>.
vadym-serdiuk closed pull request #26320: refactor!: add possibility to deploy under the URI prefix
URL: https://github.com/apache/superset/pull/26320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor!: add possibility to deploy under the URI prefix [superset]
Posted by "nachogrj (via GitHub)" <gi...@apache.org>.
nachogrj commented on PR #26320:
URL: https://github.com/apache/superset/pull/26320#issuecomment-2446320729
@jinghua-qa @geido @eschutho @rusackas @betodealmeida Could you review this PR? It is important to be able to deploy superset behind a reverse-proxy using a different URI prefix #20213 #18364 #25500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor!: add possibility to deploy under the URI prefix [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #26320:
URL: https://github.com/apache/superset/pull/26320#issuecomment-2826310629
@vadym-serdiuk is this likely to be continued, or shall we consider it inactive and close it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor!: add possibility to deploy under the URI prefix [superset]
Posted by "jbsiddall (via GitHub)" <gi...@apache.org>.
jbsiddall commented on PR #26320:
URL: https://github.com/apache/superset/pull/26320#issuecomment-2619551973
Hey, is there any news on this? I'd find ti really really useful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org