[GitHub] [hudi] yanghua commented on a change in pull request #1900: [HUDI-531]Add java doc for hudi test suite general classes

[GitBox <gi...@apache.org>]

yanghua commented on a change in pull request #1900:
URL: https://github.com/apache/hudi/pull/1900#discussion_r464144947



##########
File path: hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/dag/scheduler/DagScheduler.java
##########
@@ -48,6 +51,11 @@ public DagScheduler(WorkflowDag workflowDag, HoodieTestSuiteWriter hoodieTestSui
     this.executionContext = new ExecutionContext(null, hoodieTestSuiteWriter, deltaGenerator);
   }
 
+  /**
+   * Method to start execute workflowDags.

Review comment:
       `workflowDags ` -> `workflow DAGs `

##########
File path: hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/dag/nodes/BulkInsertNode.java
##########
@@ -24,6 +24,9 @@
 import org.apache.hudi.integ.testsuite.configuration.DeltaConfig.Config;
 import org.apache.spark.api.java.JavaRDD;
 
+/**
+ * Represents a bulkInsert Node in the DAG of operations for a workflow.

Review comment:
       `bulkInsert Node` -> `bulk insert node`?

##########
File path: hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/dag/scheduler/DagScheduler.java
##########
@@ -37,6 +37,9 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+/**
+ * The DagScheduler schedules the workflowDag.

Review comment:
       `DagScheduler ` -> `DAG scheduler`

##########
File path: hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/dag/nodes/HiveQueryNode.java
##########
@@ -30,6 +30,9 @@
 import org.apache.hudi.integ.testsuite.dag.ExecutionContext;
 import org.apache.hudi.integ.testsuite.helpers.HiveServiceProvider;
 
+/**
+ * Represents a hive query Node in the DAG of operations for a workflow.

Review comment:
       ditto

##########
File path: hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/dag/nodes/CompactNode.java
##########
@@ -26,6 +26,9 @@
 import org.apache.hudi.integ.testsuite.dag.ExecutionContext;
 import org.apache.spark.api.java.JavaRDD;
 
+/**
+ * Represents a compact Node in the DAG of operations for a workflow.

Review comment:
       ditto

##########
File path: hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/dag/nodes/CleanNode.java
##########
@@ -20,6 +20,9 @@
 
 import org.apache.hudi.integ.testsuite.dag.ExecutionContext;
 
+/**
+ * Represents a clean Node in the DAG of operations for a workflow.

Review comment:
       `Node` -> `node`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org