You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/06/01 23:16:57 UTC

[GitHub] [samza] kw2542 opened a new pull request #1371: SAMZA-2538: Update build.gradle from using config-path to job.config.loader.properties.path

kw2542 opened a new pull request #1371:
URL: https://github.com/apache/samza/pull/1371


   
   
   Symptom: Gradle tasks in samza-shell (checkpointTool, kvPerformanceTest, runJob) does not work.
   Cause: Gradle tasks are not being updated to be compatible with Samza 1.5.
   Changes: Translate configPath property to job.config.loader.factory and job.config.loader.properties.path instead of config-path.
   Tests:
   1. ./gradlew samza-shell:runJob -PconfigPath=/deploy/samza/config/wikipedia-feed.properties
   2. ./gradlew samza-shell:kvPerformanceTest -PconfigPath=file://$PWD/samza-test/src/main/config/perf/kv-perf.properties
   API Changes: None
   Upgrade Instructions: None
   Usage Instructions: None


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] mynameborat commented on a change in pull request #1371: SAMZA-2538: Update build.gradle from using config-path to job.config.loader.properties.path

Posted by GitBox <gi...@apache.org>.
mynameborat commented on a change in pull request #1371:
URL: https://github.com/apache/samza/pull/1371#discussion_r434087131



##########
File path: gradle/wrapper/gradle-wrapper.properties
##########
@@ -1,5 +1,6 @@
+#Mon Jun 01 15:50:38 PDT 2020
+distributionUrl=https\://services.gradle.org/distributions/gradle-5.2.1-all.zip
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-5.2.1-bin.zip
-zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
+zipStoreBase=GRADLE_USER_HOME

Review comment:
       nit: can we revert the ordering change?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] asfgit closed pull request #1371: SAMZA-2538: Update build.gradle from using config-path to job.config.loader.properties.path

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1371:
URL: https://github.com/apache/samza/pull/1371


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org