You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2017/12/07 16:59:34 UTC

Review Request 64420: Fix unit tests in feature branch to make them workable

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64420/
-----------------------------------------------------------

Review request for Ambari, Attila Doroszlai and Jayush Luniya.


Bugs: AMBARI-22614
    https://issues.apache.org/jira/browse/AMBARI-22614


Repository: ambari


Description
-------

Fix unit tests in feature branch to make them workable


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java fc49a24 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceFactory.java 69eb21d 
  ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 0b38b36 
  ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java 19f940f 
  ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionSchedulerThreading.java 22f23c8 
  ambari-server/src/test/java/org/apache/ambari/server/agent/HeartbeatProcessorTest.java 8a6025f 
  ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 50d4733 
  ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 4f8c423 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java fc24d2c 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/ServiceResourceDefinitionTest.java 75319ea 
  ambari-server/src/test/java/org/apache/ambari/server/checks/ComponentExistsInRepoCheckTest.java 2fe8ee0 
  ambari-server/src/test/java/org/apache/ambari/server/configuration/RecoveryConfigHelperTest.java 040b571 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java 21cf518 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 5c6f374 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java aee1952 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 9e6b98b 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProviderTest.java 387fa45 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java 8e968cc 
  ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/state/GeneralServiceCalculatedStateTest.java 0b6c3f3 
  ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java a86d125 
  ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java a03d7cc 
  ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java 158c47d 
  ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java 4e1c139 
  ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 5e5395a 
  ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterImplTest.java a52f438 
  ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 4ce7387 
  ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java be4a907 
  ambari-server/src/test/resources/cluster-settings.xml PRE-CREATION 


Diff: https://reviews.apache.org/r/64420/diff/1/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi


Re: Review Request 64420: Fix unit tests in feature branch to make them workable

Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64420/#review193254
-----------------------------------------------------------


Ship it!




Ship It!

- Attila Doroszlai


On Dec. 7, 2017, 5:59 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64420/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2017, 5:59 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai and Jayush Luniya.
> 
> 
> Bugs: AMBARI-22614
>     https://issues.apache.org/jira/browse/AMBARI-22614
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fix unit tests in feature branch to make them workable
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java fc49a24 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceFactory.java 69eb21d 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 0b38b36 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java 19f940f 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionSchedulerThreading.java 22f23c8 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/HeartbeatProcessorTest.java 8a6025f 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 50d4733 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 4f8c423 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java fc24d2c 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ServiceResourceDefinitionTest.java 75319ea 
>   ambari-server/src/test/java/org/apache/ambari/server/checks/ComponentExistsInRepoCheckTest.java 2fe8ee0 
>   ambari-server/src/test/java/org/apache/ambari/server/configuration/RecoveryConfigHelperTest.java 040b571 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java 21cf518 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 5c6f374 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java aee1952 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 9e6b98b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProviderTest.java 387fa45 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java 8e968cc 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/state/GeneralServiceCalculatedStateTest.java 0b6c3f3 
>   ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java a86d125 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java a03d7cc 
>   ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java 158c47d 
>   ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java 4e1c139 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 5e5395a 
>   ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterImplTest.java a52f438 
>   ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 4ce7387 
>   ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java be4a907 
>   ambari-server/src/test/resources/cluster-settings.xml PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64420/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>