[GitHub] [druid] clintropolis commented on a change in pull request #11402: support using mariadb connector with mysql extensions

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #11402:
URL: https://github.com/apache/druid/pull/11402#discussion_r662854336



##########
File path: core/src/main/java/org/apache/druid/utils/ConnectionUriUtils.java
##########
@@ -57,6 +67,194 @@ public static void throwIfPropertiesAreNotAllowed(
     }
   }
 
+  public static Set<String> tryParseJdbcUriParameters(String connectionUri, boolean allowUnknown)
+  {
+    if (connectionUri.startsWith(MYSQL_PREFIX)) {
+      try {
+        return tryParseMySqlConnectionUri(connectionUri);
+      }
+      catch (ClassNotFoundException notFoundMysql) {

Review comment:
       They are not currently, trying to think of a good way to test it, i guess i need some different classloaders to model different configurations or something. Any ideas?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org