You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "SwingGuy1024 (via GitHub)" <gi...@apache.org> on 2023/04/19 03:51:19 UTC
[GitHub] [commons-io] SwingGuy1024 opened a new pull request, #449: IO-789 Symbolic link file filter accepts all files, not just symbolic links
SwingGuy1024 opened a new pull request, #449:
URL: https://github.com/apache/commons-io/pull/449
This change fixed the filters, but also restructures the code slightly to facilitate Unit Testing on all platforms. (This is a challenge for this particular class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] garydgregory closed pull request #449: IO-789 Symbolic link file filter accepts all files, not just symbolic links
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory closed pull request #449: IO-789 Symbolic link file filter accepts all files, not just symbolic links
URL: https://github.com/apache/commons-io/pull/449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #449: IO-789 Symbolic link file filter accepts all files, not just symbolic links
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #449:
URL: https://github.com/apache/commons-io/pull/449#issuecomment-1514565776
Superceded by #450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] codecov-commenter commented on pull request #449: IO-789 Symbolic link file filter accepts all files, not just symbolic links
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #449:
URL: https://github.com/apache/commons-io/pull/449#issuecomment-1514207025
## [Codecov](https://codecov.io/gh/apache/commons-io/pull/449?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#449](https://codecov.io/gh/apache/commons-io/pull/449?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a273627) into [master](https://codecov.io/gh/apache/commons-io/commit/22f6525588afe563a895d6c7a70e03ede86610d1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (22f6525) will **decrease** coverage by `0.02%`.
> The diff coverage is `66.66%`.
```diff
@@ Coverage Diff @@
## master #449 +/- ##
============================================
- Coverage 84.62% 84.60% -0.02%
Complexity 3291 3291
============================================
Files 223 223
Lines 7913 7914 +1
Branches 946 946
============================================
Hits 6696 6696
Misses 970 970
- Partials 247 248 +1
```
| [Impacted Files](https://codecov.io/gh/apache/commons-io/pull/449?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../commons/io/filefilter/SymbolicLinkFileFilter.java](https://codecov.io/gh/apache/commons-io/pull/449?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvaW8vZmlsZWZpbHRlci9TeW1ib2xpY0xpbmtGaWxlRmlsdGVyLmphdmE=) | `87.50% <66.66%> (+1.78%)` | :arrow_up: |
... and [1 file with indirect coverage changes](https://codecov.io/gh/apache/commons-io/pull/449/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #449: IO-789 Symbolic link file filter accepts all files, not just symbolic links
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #449:
URL: https://github.com/apache/commons-io/pull/449#issuecomment-1514468881
@SwingGuy1024
You have 2 similar PRs for this class and this one does not have a unit test. Which PR do you want us to review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org