[PR] Fixed: Do not evaluate the area id and target of the Ajax update areas of forms twice as an expression (OFBIZ-13643) [ofbiz-framework]

["mridulpathak (via GitHub)" <gi...@apache.org>]

mridulpathak opened a new pull request, #2200:
URL: https://github.com/apache/ofbiz-framework/pull/2200

   Fixed: Do not evaluate the area id and target of the Ajax update areas of forms twice as an expression (OFBIZ-13643)
   
   Explanation:
   MacroFormRenderer and MacroCommonRenderer created ModelForm.UpdateArea objects with the String constructor from values that were already evaluated, such as the form id, the background submit refresh target, the target of the lookup auto-completer and the target window and target of a link. That constructor takes widget expressions, so the area id and the target were evaluated a second time when the Ajax parameters were created, and a value that comes from the request and contains an expression was evaluated then.
   
   These update areas are now created with UpdateArea.literal, which takes the area id and the target as they are, and a variant of it without parameters was added for them. The update areas defined in the widgets are evaluated as before.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fixed: Do not evaluate the area id and target of the Ajax update areas of forms twice as an expression (OFBIZ-13643) [ofbiz-framework]

["mridulpathak (via GitHub)" <gi...@apache.org>]

mridulpathak merged PR #2200:
URL: https://github.com/apache/ofbiz-framework/pull/2200


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org