You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/01/09 22:58:31 UTC
[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #427:
HDDS-2866. Intermittent failure in TestOzoneManagerRocksDBLogging
adoroszlai opened a new pull request #427: HDDS-2866. Intermittent failure in TestOzoneManagerRocksDBLogging
URL: https://github.com/apache/hadoop-ozone/pull/427
## What changes were proposed in this pull request?
Swap positive and negative test cases of RocksDB logging to avoid log messages from finalizer affecting the non-logging case.
https://issues.apache.org/jira/browse/HDDS-2866
## How was this patch tested?
Tested locally, as well as on branch with integration tests enabled:
```
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.749 s - in org.apache.hadoop.ozone.om.TestOzoneManagerRocksDBLogging
```
https://github.com/adoroszlai/hadoop-ozone/runs/382195722
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on issue #427: HDDS-2866.
Intermittent failure in TestOzoneManagerRocksDBLogging
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #427: HDDS-2866. Intermittent failure in TestOzoneManagerRocksDBLogging
URL: https://github.com/apache/hadoop-ozone/pull/427#issuecomment-575501048
Thanks @avijayanhwx for the review, and @xiaoyuyao for reviewing and merging this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao merged pull request #427: HDDS-2866.
Intermittent failure in TestOzoneManagerRocksDBLogging
Posted by GitBox <gi...@apache.org>.
xiaoyuyao merged pull request #427: HDDS-2866. Intermittent failure in TestOzoneManagerRocksDBLogging
URL: https://github.com/apache/hadoop-ozone/pull/427
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] avijayanhwx commented on issue #427: HDDS-2866.
Intermittent failure in TestOzoneManagerRocksDBLogging
Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on issue #427: HDDS-2866. Intermittent failure in TestOzoneManagerRocksDBLogging
URL: https://github.com/apache/hadoop-ozone/pull/427#issuecomment-574858658
LGTM +1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao commented on issue #427: HDDS-2866.
Intermittent failure in TestOzoneManagerRocksDBLogging
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on issue #427: HDDS-2866. Intermittent failure in TestOzoneManagerRocksDBLogging
URL: https://github.com/apache/hadoop-ozone/pull/427#issuecomment-575400611
Good catch. The fix LGTM, +1. I will merge it shortly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on issue #427: HDDS-2866.
Intermittent failure in TestOzoneManagerRocksDBLogging
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #427: HDDS-2866. Intermittent failure in TestOzoneManagerRocksDBLogging
URL: https://github.com/apache/hadoop-ozone/pull/427#issuecomment-572949375
@avijayanhwx @swagle please review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org