You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2016/06/29 15:35:04 UTC
[GitHub] flink pull request #2186: [licenses] Remove not included dependency from LIC...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/2186
[licenses] Remove not included dependency from LICENSE
Flink does not include the anchor.js file but loads it dynamically when displaying
the documentation. Therefore, we don't have to include anchor.js in the LICENSE file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink checkLicense
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2186.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2186
----
commit aecdb26d19915d826fadb80b1e8582b05e514207
Author: Till Rohrmann <tr...@apache.org>
Date: 2016-06-29T14:26:16Z
[licenses] Remove not included dependency from LICENSE
Flink does not include the anchor.js file but loads it dynamically when displaying
the documentation. Therefore, we don't have to include anchor.js in the LICENSE file.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2186: [licenses] Remove not included dependency from LICENSE
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2186
It works also offline but you won't have the anchor functionality available. In fact, you would also miss the bootstrap and the jquery library. Without these libraries the documentation looks really ugly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2186: [licenses] Remove not included dependency from LICENSE
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2186
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2186: [licenses] Remove not included dependency from LICENSE
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2186
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2186: [licenses] Remove not included dependency from LIC...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2186
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2186: [licenses] Remove not included dependency from LICENSE
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2186
Is the documentation still usable offline?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---