[GitHub] [trafficserver] ywkaras commented on a diff in pull request #9228: Hugepage support for iobuffer

[GitBox <gi...@apache.org>]

ywkaras commented on code in PR #9228:
URL: https://github.com/apache/trafficserver/pull/9228#discussion_r1061625498


##########
include/tscore/Allocator.h:
##########
@@ -97,16 +97,18 @@ class FreelistAllocator
     @param chunk_size number of units to be allocated if free pool is empty.
     @param alignment of objects must be a power of 2.
   */
-  FreelistAllocator(const char *name, unsigned int element_size, unsigned int chunk_size = 128, unsigned int alignment = 8)
+  FreelistAllocator(const char *name, unsigned int element_size, unsigned int chunk_size = 128, unsigned int alignment = 8,
+                    unsigned int use_hugepages = 0)

Review Comment:
   To use bool instead of an integral type when the only values in the variable are 1 or 0.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org