You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/04/23 12:24:17 UTC

[GitHub] [incubator-mxnet] perdasilva commented on a change in pull request #14726: [MXNET-1377] Add static-dependencies licenses

perdasilva commented on a change in pull request #14726: [MXNET-1377] Add static-dependencies licenses
URL: https://github.com/apache/incubator-mxnet/pull/14726#discussion_r277649164
 
 

 ##########
 File path: tools/staticbuild/build_lib.sh
 ##########
 @@ -48,12 +47,6 @@ if [[ $VARIANT == *mkl ]]; then
     cp 3rdparty/mkldnn/build/install/lib/$IOMP_LIBFILE lib
     cp 3rdparty/mkldnn/build/install/lib/$MKLML_LIBFILE lib
     cp 3rdparty/mkldnn/build/install/lib/$MKLDNN_LIBFILE lib
-    cp 3rdparty/mkldnn/build/install/$MKLDNN_LICENSE lib
 
 Review comment:
   Do we not need to copy the mkl-dnn and cub licenses anymore?
   I couldn't find them in LICENSE.binary.dependencies.
   
   Also, these changes have broken the `pip/setup.py`. I will post a PR and add you as reviewer =)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services