You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "jovanpavl-db (via GitHub)" <gi...@apache.org> on 2024/11/01 17:59:02 UTC
[PR] [SPARK-49670][SQL]Enable trim collation for all passthrough expressions [spark]
jovanpavl-db opened a new pull request, #48739:
URL: https://github.com/apache/spark/pull/48739
### What changes were proposed in this pull request?
Enabling usage of passthrough expressions for trim collation.
**NOTE: it looks like a tons of changes but only changes are:
for each expression set supportsTrimCollation=true and add tests.**
### Why are the changes needed?
So that all expressions could be used with trim collation
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Add tests to CollationSqlExpressionsSuite
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49670][SQL] Enable trim collation for all passthrough expressions [spark]
Posted by "vladanvasi-db (via GitHub)" <gi...@apache.org>.
vladanvasi-db commented on code in PR #48739:
URL: https://github.com/apache/spark/pull/48739#discussion_r1856295161
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala:
##########
@@ -582,7 +582,10 @@ case class StringToMap(text: Expression, pairDelim: Expression, keyValueDelim: E
override def third: Expression = keyValueDelim
override def inputTypes: Seq[AbstractDataType] =
- Seq(StringTypeNonCSAICollation, StringTypeNonCSAICollation, StringTypeNonCSAICollation)
+ Seq(
+ StringTypeNonCSAICollation(supportsTrimCollation = true),
+ StringTypeNonCSAICollation(supportsTrimCollation = true),
+ StringTypeNonCSAICollation(supportsTrimCollation = true))
Review Comment:
Sorry for the confusion, latest update for this is that we will disable collations support for all expressions that are using regexes in them. Since `str_to_map` uses regex split inside its implementation, it will not be enabled even for `UTF8_BINARY_TRIM` collation. Therefore, please remove the changes for `str_to_map` expression, and then I will approve the PR. Btw, the disablement will be done in a separate PR, you do not have to do anything else than reverting changes for `str_to_map`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49670][SQL] Enable trim collation for all passthrough expressions [spark]
Posted by "uros-db (via GitHub)" <gi...@apache.org>.
uros-db commented on code in PR #48739:
URL: https://github.com/apache/spark/pull/48739#discussion_r1862388731
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala:
##########
@@ -582,7 +582,10 @@ case class StringToMap(text: Expression, pairDelim: Expression, keyValueDelim: E
override def third: Expression = keyValueDelim
override def inputTypes: Seq[AbstractDataType] =
- Seq(StringTypeNonCSAICollation, StringTypeNonCSAICollation, StringTypeNonCSAICollation)
+ Seq(
+ StringTypeNonCSAICollation,
+ StringTypeNonCSAICollation,
+ StringTypeNonCSAICollation)
Review Comment:
these changes don't really do anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49670][SQL] Enable trim collation for all passthrough expressions [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #48739:
URL: https://github.com/apache/spark/pull/48739#discussion_r1855172770
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationAwareUTF8String.java:
##########
@@ -1530,20 +1530,29 @@ public static UTF8String trimRight(
public static UTF8String[] splitSQL(final UTF8String input, final UTF8String delim,
final int limit, final int collationId) {
- if (CollationFactory.fetchCollation(collationId).isUtf8BinaryType) {
+ CollationFactory.Collation collation = CollationFactory.fetchCollation(collationId);
+ if(collation.isUtf8BinaryType && !collation.supportsSpaceTrimming){
Review Comment:
```suggestion
if (collation.isUtf8BinaryType && !collation.supportsSpaceTrimming){
```
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java:
##########
@@ -37,13 +37,15 @@ public final class CollationSupport {
public static class StringSplitSQL {
public static UTF8String[] exec(final UTF8String s, UTF8String d, final int collationId) {
CollationFactory.Collation collation = CollationFactory.fetchCollation(collationId);
- if (collation.supportsSpaceTrimming) {
- d = CollationFactory.applyTrimmingPolicy(d, collationId);
+ if(collation.isUtf8BinaryType && !collation.supportsSpaceTrimming){
Review Comment:
```suggestion
if (collation.isUtf8BinaryType && !collation.supportsSpaceTrimming){
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49670][SQL]Enable trim collation for all passthrough expressions [spark]
Posted by "jovanpavl-db (via GitHub)" <gi...@apache.org>.
jovanpavl-db commented on code in PR #48739:
URL: https://github.com/apache/spark/pull/48739#discussion_r1854134774
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala:
##########
@@ -582,7 +582,10 @@ case class StringToMap(text: Expression, pairDelim: Expression, keyValueDelim: E
override def third: Expression = keyValueDelim
override def inputTypes: Seq[AbstractDataType] =
- Seq(StringTypeNonCSAICollation, StringTypeNonCSAICollation, StringTypeNonCSAICollation)
+ Seq(
+ StringTypeNonCSAICollation(supportsTrimCollation = true),
+ StringTypeNonCSAICollation(supportsTrimCollation = true),
+ StringTypeNonCSAICollation(supportsTrimCollation = true))
Review Comment:
That's good point, we did implement `StringSplitSQL` expression as trim collation aware, but not in CollationAwareUTF8String itself. Will fix this and add tests for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49670][SQL] Enable trim collation for all passthrough expressions [spark]
Posted by "uros-db (via GitHub)" <gi...@apache.org>.
uros-db commented on code in PR #48739:
URL: https://github.com/apache/spark/pull/48739#discussion_r1862388731
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala:
##########
@@ -582,7 +582,10 @@ case class StringToMap(text: Expression, pairDelim: Expression, keyValueDelim: E
override def third: Expression = keyValueDelim
override def inputTypes: Seq[AbstractDataType] =
- Seq(StringTypeNonCSAICollation, StringTypeNonCSAICollation, StringTypeNonCSAICollation)
+ Seq(
+ StringTypeNonCSAICollation,
+ StringTypeNonCSAICollation,
+ StringTypeNonCSAICollation)
Review Comment:
these changes don't really do anything? I figure that this is intentional, due to the `StringToMap` expression behaviour (which is generally collation-aware), but in that case please undo the changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49670][SQL] Enable trim collation for all passthrough expressions [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #48739:
URL: https://github.com/apache/spark/pull/48739#issuecomment-2517509531
+1, LGTM. Merging to master.
Thank you, @jovanpavl-db and @uros-db @vladanvasi-db for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49670][SQL]Enable trim collation for all passthrough expressions [spark]
Posted by "jovanpavl-db (via GitHub)" <gi...@apache.org>.
jovanpavl-db commented on PR #48739:
URL: https://github.com/apache/spark/pull/48739#issuecomment-2493869581
Added more test, @MaxGekk can we merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49670][SQL] Enable trim collation for all passthrough expressions [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #48739:
URL: https://github.com/apache/spark/pull/48739#issuecomment-2500188663
@uros-db Are you ok w/ the changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49670][SQL] Enable trim collation for all passthrough expressions [spark]
Posted by "uros-db (via GitHub)" <gi...@apache.org>.
uros-db commented on PR #48739:
URL: https://github.com/apache/spark/pull/48739#issuecomment-2506446924
in a follow-up, we should actually make `supportsTrimCollation = true` the default
please mention this intent in the PR description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49670][SQL]Enable trim collation for all passthrough expressions [spark]
Posted by "jovanpavl-db (via GitHub)" <gi...@apache.org>.
jovanpavl-db commented on code in PR #48739:
URL: https://github.com/apache/spark/pull/48739#discussion_r1845637042
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##########
@@ -1720,9 +1981,13 @@ class CollationSQLExpressionsSuite
case class DateFormatTestCase[R](date: String, format: String, collation: String, result: R)
val testCases = Seq(
DateFormatTestCase("2021-01-01", "yyyy-MM-dd", "UTF8_BINARY", "2021-01-01"),
+ DateFormatTestCase("2021-01-01", "yyyy-MM-dd", "UTF8_BINARY_RTRIM", "2021-01-01"),
Review Comment:
Actually it won't matter as _RTRIM is not meant to be applied to tha, it will have completrely same effect as regular collation (they are passthrough).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49670][SQL] Enable trim collation for all passthrough expressions [spark]
Posted by "jovanpavl-db (via GitHub)" <gi...@apache.org>.
jovanpavl-db commented on code in PR #48739:
URL: https://github.com/apache/spark/pull/48739#discussion_r1856355958
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala:
##########
@@ -582,7 +582,10 @@ case class StringToMap(text: Expression, pairDelim: Expression, keyValueDelim: E
override def third: Expression = keyValueDelim
override def inputTypes: Seq[AbstractDataType] =
- Seq(StringTypeNonCSAICollation, StringTypeNonCSAICollation, StringTypeNonCSAICollation)
+ Seq(
+ StringTypeNonCSAICollation(supportsTrimCollation = true),
+ StringTypeNonCSAICollation(supportsTrimCollation = true),
+ StringTypeNonCSAICollation(supportsTrimCollation = true))
Review Comment:
Makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49670][SQL] Enable trim collation for all passthrough expressions [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #48739: [SPARK-49670][SQL] Enable trim collation for all passthrough expressions
URL: https://github.com/apache/spark/pull/48739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49670][SQL] Enable trim collation for all passthrough expressions [spark]
Posted by "jovanpavl-db (via GitHub)" <gi...@apache.org>.
jovanpavl-db commented on PR #48739:
URL: https://github.com/apache/spark/pull/48739#issuecomment-2511384822
@MaxGekk can we check in this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49670][SQL]Enable trim collation for all passthrough expressions [spark]
Posted by "uros-db (via GitHub)" <gi...@apache.org>.
uros-db commented on code in PR #48739:
URL: https://github.com/apache/spark/pull/48739#discussion_r1826137516
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##########
@@ -2760,6 +3076,7 @@ class CollationSQLExpressionsSuite
}
}
+ // TODO: fix
Review Comment:
leftover TODO?
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##########
@@ -2887,6 +3204,7 @@ class CollationSQLExpressionsSuite
}
}
+ // TODO: fix
Review Comment:
leftover TODO?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49670][SQL]Enable trim collation for all passthrough expressions [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #48739:
URL: https://github.com/apache/spark/pull/48739#discussion_r1835472216
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##########
@@ -1720,9 +1981,13 @@ class CollationSQLExpressionsSuite
case class DateFormatTestCase[R](date: String, format: String, collation: String, result: R)
val testCases = Seq(
DateFormatTestCase("2021-01-01", "yyyy-MM-dd", "UTF8_BINARY", "2021-01-01"),
+ DateFormatTestCase("2021-01-01", "yyyy-MM-dd", "UTF8_BINARY_RTRIM", "2021-01-01"),
Review Comment:
Could you modify the input in all cases and check that `_RTRIM` does work actually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49670][SQL] Enable trim collation for all passthrough expressions [spark]
Posted by "jovanpavl-db (via GitHub)" <gi...@apache.org>.
jovanpavl-db commented on PR #48739:
URL: https://github.com/apache/spark/pull/48739#issuecomment-2506259832
Kind ping on this @MaxGekk, @uros-db.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49670][SQL] Enable trim collation for all passthrough expressions [spark]
Posted by "jovanpavl-db (via GitHub)" <gi...@apache.org>.
jovanpavl-db closed pull request #48739: [SPARK-49670][SQL] Enable trim collation for all passthrough expressions
URL: https://github.com/apache/spark/pull/48739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49670][SQL]Enable trim collation for all passthrough expressions [spark]
Posted by "uros-db (via GitHub)" <gi...@apache.org>.
uros-db commented on code in PR #48739:
URL: https://github.com/apache/spark/pull/48739#discussion_r1826137770
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##########
@@ -1270,6 +1442,7 @@ class CollationSQLExpressionsSuite
)
}
+ // TODO: fix
Review Comment:
leftover TODO?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49670][SQL]Enable trim collation for all passthrough expressions [spark]
Posted by "vladanvasi-db (via GitHub)" <gi...@apache.org>.
vladanvasi-db commented on code in PR #48739:
URL: https://github.com/apache/spark/pull/48739#discussion_r1854081861
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala:
##########
@@ -582,7 +582,10 @@ case class StringToMap(text: Expression, pairDelim: Expression, keyValueDelim: E
override def third: Expression = keyValueDelim
override def inputTypes: Seq[AbstractDataType] =
- Seq(StringTypeNonCSAICollation, StringTypeNonCSAICollation, StringTypeNonCSAICollation)
+ Seq(
+ StringTypeNonCSAICollation(supportsTrimCollation = true),
+ StringTypeNonCSAICollation(supportsTrimCollation = true),
+ StringTypeNonCSAICollation(supportsTrimCollation = true))
Review Comment:
Is `str_to_map` a passthrough expression, since it uses `splitSQL` to split the string. Also, is `splitSQL` in the `CollationAwareUTF8String` trim-aware?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49670][SQL]Enable trim collation for all passthrough expressions [spark]
Posted by "jovanpavl-db (via GitHub)" <gi...@apache.org>.
jovanpavl-db commented on PR #48739:
URL: https://github.com/apache/spark/pull/48739#issuecomment-2495066008
> @jovanpavl-db can you add some tests to `collations.sql` golden file, I'm pretty sure that there are some existing tests for `str_to_map` and `array_union` (maybe there are some other passthrough expressions in that file)?
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org