You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jason810496 (via GitHub)" <gi...@apache.org> on 2026/07/07 11:28:22 UTC

[PR] Fix remote task log pollution leaking out of S3 log handler test [airflow]

jason810496 opened a new pull request, #69539:
URL: https://github.com/apache/airflow/pull/69539

   - related: #69520
   
   ## Why
   
   `test_read_remote_logs_with_real_s3_remote_log_io` assigns `_ActiveLoggingConfig.remote_task_log` directly and never restores it, so any log-reading test collected afterwards (e.g. `test_log_reader.py` when run after `test_log_handlers.py`) tries to fetch logs from the long-gone mocked S3 bucket and fails with `InvalidAccessKeyId`.
   
   ## What
   
   - Set `_ActiveLoggingConfig.remote_task_log` via `monkeypatch.setattr` so it is restored after the test.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [x] Yes, with help of Claude Code (Fable 5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix remote task log pollution leaking out of S3 log handler test [airflow]

Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck merged PR #69539:
URL: https://github.com/apache/airflow/pull/69539


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org