You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "anjiahao1 (via GitHub)" <gi...@apache.org> on 2024/07/29 07:42:07 UTC
[PR] arm_backtrace_unwind:Make the backtrace search the entire stack as much as possible [nuttx]
anjiahao1 opened a new pull request, #12787:
URL: https://github.com/apache/nuttx/pull/12787
## Summary
Expand the backtrace search scope,
Similarly, the problem that the idle thread's lr is a random value can be fixed
fix it https://github.com/apache/nuttx/issues/12687
## Impact
arm unwind
## Testing
qemu use an547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm_backtrace_unwind:Make the backtrace search the entire stack as much as possible [nuttx]
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #12787:
URL: https://github.com/apache/nuttx/pull/12787#discussion_r1694932705
##########
arch/arm/src/common/arm_backtrace_unwind.c:
##########
@@ -728,11 +732,14 @@ int up_backtrace(struct tcb_s *tcb,
frame.sp = frame.fp;
frame.stack_top = (unsigned long)rtcb->stack_base_ptr +
Review Comment:
```suggestion
frame.stack_base = (unsigned long)rtcb->stack_base_ptr;
frame.stack_top = frame.stack_base + rtcb->adj_stack_size;
```
assign all stack base before top
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm_backtrace_unwind:Make the backtrace search the entire stack as much as possible [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #12787:
URL: https://github.com/apache/nuttx/pull/12787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org