You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Peter Rozsa (Jira)" <ji...@apache.org> on 2022/11/24 13:56:00 UTC
[jira] [Assigned] (IMPALA-10698) Remove branching based on MetastoreShim.getMajorVersion()
[ https://issues.apache.org/jira/browse/IMPALA-10698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Rozsa reassigned IMPALA-10698:
------------------------------------
Assignee: Peter Rozsa
> Remove branching based on MetastoreShim.getMajorVersion()
> ---------------------------------------------------------
>
> Key: IMPALA-10698
> URL: https://issues.apache.org/jira/browse/IMPALA-10698
> Project: IMPALA
> Issue Type: Improvement
> Components: Frontend
> Reporter: Zoltán Borók-Nagy
> Assignee: Peter Rozsa
> Priority: Major
> Labels: newbie, ramp-up
>
> IMPALA-9731 dropped support for Hive 2 and removed most code associated with it.
> However we still have if statements that check MetastoreShim.getMajorVersion().
> One can check it with:
> {noformat}
> git grep getMajorVersion
> {noformat}
> It would be nice to get rid of these because the MetastoreShim.getMajorVersion() == 2 branches are dead code now.
> Moreover, in the test code there are still some places that check for HIVE_MAJOR_VERSION == 2, e.g.:
> https://github.com/apache/impala/blob/c10e7c969dfcc4847a8f7708940f4aa1852dbee4/tests/metadata/test_hms_integration.py#L215
> These can be also removed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org