[jira] [Commented] (KYLIN-2637) The tips is not shown after creating project successfully.

["Billy Liu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020548#comment-16020548 ] 

Billy Liu commented on KYLIN-2637:
----------------------------------

LGTM. Thanks [~peng.jianhua], patch merged. 

https://github.com/apache/kylin/commit/ce6e3ede2f670bf037a55234630b85098265075a

> The tips is not shown after creating project successfully.
> ----------------------------------------------------------
>
>                 Key: KYLIN-2637
>                 URL: https://issues.apache.org/jira/browse/KYLIN-2637
>             Project: Kylin
>          Issue Type: Bug
>          Components: Web 
>    Affects Versions: v2.1.0
>            Reporter: peng.jianhua
>            Assignee: peng.jianhua
>            Priority: Trivial
>             Fix For: v2.1.0
>
>         Attachments: 0001-KYLIN-2637-The-tips-is-not-shown-after-creating-proj.patch
>
>
> The following code in page.js:
>         SweetAlert.swal('Success!', 'New project created successfully!', 'success');
>         $modalInstance.dismiss('cancel');
>         $cookieStore.put("project", newProj.name);
>         location.reload();
> 'SweetAlert' is invoked before 'location.reload()', so it cannot be shown.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)