You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/01/20 08:30:13 UTC

[GitHub] [hudi] wangxianghu commented on pull request #2466: [MINOR] Remove redundant judgments

wangxianghu commented on pull request #2466:
URL: https://github.com/apache/hudi/pull/2466#issuecomment-763429076


   > > @teeyog This check seems necessary, since it is in a for loop
   > 
   > @wangxianghu Thank you for your review
   > `recordsToAppend` is the smaller value of `totalUnassignedInserts` and another value, that is `totalUnassignedInserts>=recordsToAppend`, that is to say `recordsToAppend>0`, then totalUnassignedInserts must be greater than 0
   
   My bad, you're right


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org