You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by lovexi <gi...@git.apache.org> on 2016/07/25 01:53:12 UTC
[GitHub] spark pull request #14338: Make parameters configurable in BlockManager
GitHub user lovexi opened a pull request:
https://github.com/apache/spark/pull/14338
Make parameters configurable in BlockManager
## What changes were proposed in this pull request?
Make parameters configurable in BlockManager class, such as max_attempts and sleep_time
## How was this patch tested?
Using existing test cases
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lovexi/spark configurable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14338.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14338
----
commit 9f693b227be83717fcc76067c9fa5b8849362a5b
Author: Yangyang Liu <ya...@fb.com>
Date: 2016-07-24T19:16:40Z
Make parameters configurable in BlockManager
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14338: [SPARK-16701] Make parameters configurable in Blo...
Posted by lovexi <gi...@git.apache.org>.
Github user lovexi closed the pull request at:
https://github.com/apache/spark/pull/14338
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14338: [SPARK-16701] Make parameters configurable in BlockManag...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14338
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14338: [SPARK-16701] Make parameters configurable in BlockManag...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the issue:
https://github.com/apache/spark/pull/14338
I am opposed to this change because these are internal states that were never intended for the user to tweak. If there is a specific problem you're trying to fix then we should address that more generally instead. Please close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org