[GitHub] [tvm] masahi commented on a diff in pull request #11228: [QNN] Enable constant folding for QNN operations.

[GitBox <gi...@apache.org>]

masahi commented on code in PR #11228:
URL: https://github.com/apache/tvm/pull/11228#discussion_r869064797


##########
include/tvm/relay/transform.h:
##########
@@ -105,9 +105,11 @@ TVM_DLL Pass LazyGradientInit();
 /*!
  * \brief Fold constant expressions.
  *
+ * \param fold_qnn Whether to fold constants for QNN operations.
+ *
  * \return The pass.
  */
-TVM_DLL Pass FoldConstant();
+TVM_DLL Pass FoldConstant(bool fold_qnn = false);

Review Comment:
   Is there a case we don't want to fold QNN ops?



##########
include/tvm/relay/transform.h:
##########
@@ -105,9 +105,11 @@ TVM_DLL Pass LazyGradientInit();
 /*!
  * \brief Fold constant expressions.
  *
+ * \param fold_qnn Whether to fold constants for QNN operations.
+ *
  * \return The pass.
  */
-TVM_DLL Pass FoldConstant();
+TVM_DLL Pass FoldConstant(bool fold_qnn = false);

Review Comment:
   Is there a case where we don't want to fold QNN ops?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org