[GitHub] [accumulo] milleruntime commented on issue #1415: Update Apilyzer to treat core.iterators as API

[GitBox <gi...@apache.org>]

milleruntime commented on issue #1415: Update Apilyzer to treat core.iterators as API
URL: https://github.com/apache/accumulo/issues/1415#issuecomment-553047285
 
 
   I modified the core/pom.xml as so:
   ```
   -                <include>org[.]apache[.]accumulo[.]core[.]iterators[.]IteratorUtil[$]IteratorScope</include>
   +                <include>org[.]apache[.]accumulo[.]core[.]iterators[.].*</include>
   ```
   And saw the following failures:
   ```
     METHOD_RETURN        org.apache.accumulo.core.iterators.IteratorEnvironment       getServiceEnv(...)                  org.apache.accumulo.core.spi.common.ServiceEnvironment
     FIELD                org.apache.accumulo.core.iterators.user.VisibilityFilter     cache                               org.apache.commons.collections4.map.LRUMap
     FIELD                org.apache.accumulo.core.iterators.user.TransformingIterator log                                 org.slf4j.Logger
   ```
   I added the first method to IteratorEnvironment as a replacement for AccumuloConfiguration.  It seems that SPI has now entered into the quasi-API limbo, where iterators have lived for some time.  Perhaps SPI should be declared as public API along with iterators.  Even if SPI doesn't affect data like iterators do, it has a nice way to access server configuration.
   
   It seems like the LRUMap was made protected so users could override it with a different implementation. Whatever the case, I think this type could be a java.util.Map.
   
   The logger should probably just be private.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services