You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org> on 2019/04/15 20:30:36 UTC

[Impala-ASF-CR] Log scanner Open() errors

Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13018


Change subject: Log scanner Open() errors
......................................................................

Log scanner Open() errors

While the status is propagated to the runtime profile, it helps
to have it in the log file in cases where the profile is not
available.

Testing: Verified the message is logged by setting PREPARE_SCANNER
debug action.

Change-Id: I595d509ca24077b924923fa9aa4cdb912c21c9f2
---
M be/src/exec/hdfs-scan-node.cc
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/13018/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I595d509ca24077b924923fa9aa4cdb912c21c9f2
Gerrit-Change-Number: 13018
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>

[Impala-ASF-CR] Log scanner Open() errors

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13018 )

Change subject: Log scanner Open() errors
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I595d509ca24077b924923fa9aa4cdb912c21c9f2
Gerrit-Change-Number: 13018
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Apr 2019 06:29:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Log scanner Open() errors

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13018 )

Change subject: Log scanner Open() errors
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I595d509ca24077b924923fa9aa4cdb912c21c9f2
Gerrit-Change-Number: 13018
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Apr 2019 11:56:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Log scanner Open() errors

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13018 )

Change subject: Log scanner Open() errors
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I595d509ca24077b924923fa9aa4cdb912c21c9f2
Gerrit-Change-Number: 13018
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Apr 2019 05:45:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Log scanner Open() errors

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13018 )

Change subject: Log scanner Open() errors
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4026/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I595d509ca24077b924923fa9aa4cdb912c21c9f2
Gerrit-Change-Number: 13018
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Apr 2019 06:29:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Log scanner Open() errors

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13018 )

Change subject: Log scanner Open() errors
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2785/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I595d509ca24077b924923fa9aa4cdb912c21c9f2
Gerrit-Change-Number: 13018
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Apr 2019 21:12:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Log scanner Open() errors

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13018 )

Change subject: Log scanner Open() errors
......................................................................

Log scanner Open() errors

While the status is propagated to the runtime profile, it helps
to have it in the log file in cases where the profile is not
available.

Testing: Verified the message is logged by setting PREPARE_SCANNER
debug action.

Change-Id: I595d509ca24077b924923fa9aa4cdb912c21c9f2
Reviewed-on: http://gerrit.cloudera.org:8080/13018
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/hdfs-scan-node.cc
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I595d509ca24077b924923fa9aa4cdb912c21c9f2
Gerrit-Change-Number: 13018
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>