[GitHub] [beam] kkucharc commented on a change in pull request #12527: [BEAM-10672] Added Python Combine load tests for streaming on Dataflow

[GitBox <gi...@apache.org>]

kkucharc commented on a change in pull request #12527:
URL: https://github.com/apache/beam/pull/12527#discussion_r468725264



##########
File path: .test-infra/jenkins/job_LoadTests_Combine_Python.groovy
##########
@@ -93,15 +93,23 @@ def loadTestConfigurations = { datasetName ->
         top_count            : 20,
       ]
     ],
-  ].each { test -> test.pipelineOptions.putAll(additionalPipelineArgs) }
+  ]
+  .each { test -> test.pipelineOptions.putAll(additionalPipelineArgs) }
+  .each{ test -> (jobType!='streaming') ?: addStreamingOptions(test) }

Review comment:
       Sure, thanks :)

##########
File path: .test-infra/jenkins/job_LoadTests_Combine_Python.groovy
##########
@@ -113,13 +121,31 @@ PhraseTriggeringPostCommitBuilder.postCommitJob(
     this
     ) {
       additionalPipelineArgs = [:]
-      batchLoadTestJob(delegate, CommonTestProperties.TriggeringContext.PR)
+      loadTestJob(delegate, CommonTestProperties.TriggeringContext.PR, "batch")
     }
 
 CronJobBuilder.cronJob('beam_LoadTests_Python_Combine_Dataflow_Batch', 'H 15 * * *', this) {
   additionalPipelineArgs = [
     influx_db_name: InfluxDBCredentialsHelper.InfluxDBDatabaseName,
     influx_hostname: InfluxDBCredentialsHelper.InfluxDBHostname,
   ]
-  batchLoadTestJob(delegate, CommonTestProperties.TriggeringContext.POST_COMMIT)
+  loadTestJob(delegate, CommonTestProperties.TriggeringContext.POST_COMMIT, "batch")
 }
+
+PhraseTriggeringPostCommitBuilder.postCommitJob(
+    'beam_LoadTests_Python_Combine_Dataflow_Streaming',
+    'Run Python Load Tests Combine Dataflow Streaming',
+    'Load Tests Python Combine Dataflow Streaming suite',
+    this
+    ) {
+      additionalPipelineArgs = [:]
+      loadTestJob(delegate, CommonTestProperties.TriggeringContext.PR, "streaming")
+    }
+
+CronJobBuilder.cronJob('beam_LoadTests_Python_Combine_Dataflow_Streaming', 'H 15 * * *', this) {
+  additionalPipelineArgs = [
+    influx_db_name: InfluxDBCredentialsHelper.InfluxDBDatabaseName,
+    influx_hostname: InfluxDBCredentialsHelper.InfluxDBHostname,
+  ]
+  loadTestJob(delegate, CommonTestProperties.TriggeringContext.POST_COMMIT, "streaming")
+}

Review comment:
       Sure, thanks a lot :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org