You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2018/03/29 11:36:56 UTC
[camel] branch master updated (7bf2349 -> 6f4ba3f)
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git.
from 7bf2349 CAMEL-12382: FileConsumer - Allow to delay readLock release tasks on idempotent read-lock
new 5877786 CAMEL-10098: Added explanation to class javadoc about must use String parameter type.
new 6f4ba3f CAMEL-12382: FileConsumer - Allow to delay readLock release tasks on idempotent read-lock
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../strategy/FileIdempotentChangedRepositoryReadLockStrategy.java | 3 ++-
.../main/java/org/apache/camel/spi/ExchangeIdempotentRepository.java | 5 +++++
.../src/main/java/org/apache/camel/spi/IdempotentRepository.java | 5 +++++
.../processor/idempotent/jdbc/AbstractJdbcMessageIdRepository.java | 5 +++++
4 files changed, 17 insertions(+), 1 deletion(-)
--
To stop receiving notification emails like this one, please contact
davsclaus@apache.org.
[camel] 01/02: CAMEL-10098: Added explanation to class javadoc
about must use String parameter type.
Posted by da...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 5877786a5dc483e9340716abc6eeab0f0da69bf2
Author: Claus Ibsen <cl...@gmail.com>
AuthorDate: Thu Mar 29 13:35:59 2018 +0200
CAMEL-10098: Added explanation to class javadoc about must use String parameter type.
---
.../main/java/org/apache/camel/spi/ExchangeIdempotentRepository.java | 5 +++++
.../src/main/java/org/apache/camel/spi/IdempotentRepository.java | 5 +++++
.../processor/idempotent/jdbc/AbstractJdbcMessageIdRepository.java | 5 +++++
3 files changed, 15 insertions(+)
diff --git a/camel-core/src/main/java/org/apache/camel/spi/ExchangeIdempotentRepository.java b/camel-core/src/main/java/org/apache/camel/spi/ExchangeIdempotentRepository.java
index f3e49d2..aff7304 100644
--- a/camel-core/src/main/java/org/apache/camel/spi/ExchangeIdempotentRepository.java
+++ b/camel-core/src/main/java/org/apache/camel/spi/ExchangeIdempotentRepository.java
@@ -33,6 +33,11 @@ import org.apache.camel.Exchange;
* <p/>
* This repository supports the operations to pass in the current exchange, which can be needed by some implementations
* such as the JPA idempotent consumer.
+ * <p/>
+ * <b>Important:</b> Implementations of this should use <tt>String</tt> as the generic type as that is
+ * what is required by Camel to allow using the idempotent repository with the Idempotent Consumer EIP
+ * and also as file consumer read-lock. It was a mistake to make {@link IdempotentRepository} parameterized,
+ * as it should have been a pre-configured to use a <tt>String</tt> type.
*
* @version
*/
diff --git a/camel-core/src/main/java/org/apache/camel/spi/IdempotentRepository.java b/camel-core/src/main/java/org/apache/camel/spi/IdempotentRepository.java
index 6435c69..cc3724b 100644
--- a/camel-core/src/main/java/org/apache/camel/spi/IdempotentRepository.java
+++ b/camel-core/src/main/java/org/apache/camel/spi/IdempotentRepository.java
@@ -33,6 +33,11 @@ import org.apache.camel.Service;
* <p/>
* Implementations for the <a href="http://camel.apache.org/idempotent-consumer.html">idempotent consumer EIP</a>
* should favor using {@link org.apache.camel.spi.ExchangeIdempotentRepository} instead.
+ * <p/>
+ * <b>Important:</b> Implementations of this should use <tt>String</tt> as the generic type as that is
+ * what is required by Camel to allow using the idempotent repository with the Idempotent Consumer EIP
+ * and also as file consumer read-lock. It was a mistake to make {@link IdempotentRepository} parameterized,
+ * as it should have been a pre-configured to use a <tt>String</tt> type.
*
* @version
* @see org.apache.camel.spi.ExchangeIdempotentRepository
diff --git a/components/camel-sql/src/main/java/org/apache/camel/processor/idempotent/jdbc/AbstractJdbcMessageIdRepository.java b/components/camel-sql/src/main/java/org/apache/camel/processor/idempotent/jdbc/AbstractJdbcMessageIdRepository.java
index 3443ffb..d19e85e 100644
--- a/components/camel-sql/src/main/java/org/apache/camel/processor/idempotent/jdbc/AbstractJdbcMessageIdRepository.java
+++ b/components/camel-sql/src/main/java/org/apache/camel/processor/idempotent/jdbc/AbstractJdbcMessageIdRepository.java
@@ -42,6 +42,11 @@ import org.springframework.transaction.support.TransactionTemplate;
* </ul>
* <p/>
* These methods should perform the named database operation.
+ * <p/>
+ * <b>Important:</b> Implementations of this should use <tt>String</tt> as the generic type as that is
+ * what is required by Camel to allow using the idempotent repository with the Idempotent Consumer EIP
+ * and also as file consumer read-lock. It was a mistake to make {@link IdempotentRepository} parameterized,
+ * as it should have been a pre-configured to use a <tt>String</tt> type.
*/
@ManagedResource(description = "JDBC IdempotentRepository")
public abstract class AbstractJdbcMessageIdRepository<T> extends ServiceSupport implements IdempotentRepository<T> {
--
To stop receiving notification emails like this one, please contact
davsclaus@apache.org.
[camel] 02/02: CAMEL-12382: FileConsumer - Allow to delay readLock
release tasks on idempotent read-lock
Posted by da...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 6f4ba3f9d2761f8ee271f2e9a61abae7fd2e7bef
Author: Claus Ibsen <cl...@gmail.com>
AuthorDate: Thu Mar 29 13:36:47 2018 +0200
CAMEL-12382: FileConsumer - Allow to delay readLock release tasks on idempotent read-lock
---
.../file/strategy/FileIdempotentChangedRepositoryReadLockStrategy.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/camel-core/src/main/java/org/apache/camel/component/file/strategy/FileIdempotentChangedRepositoryReadLockStrategy.java b/camel-core/src/main/java/org/apache/camel/component/file/strategy/FileIdempotentChangedRepositoryReadLockStrategy.java
index 0f12f00..7ae8ba2 100644
--- a/camel-core/src/main/java/org/apache/camel/component/file/strategy/FileIdempotentChangedRepositoryReadLockStrategy.java
+++ b/camel-core/src/main/java/org/apache/camel/component/file/strategy/FileIdempotentChangedRepositoryReadLockStrategy.java
@@ -307,7 +307,8 @@ public class FileIdempotentChangedRepositoryReadLockStrategy extends ServiceSupp
ObjectHelper.notNull(idempotentRepository, "idempotentRepository", this);
if (readLockIdempotentReleaseAsync && readLockIdempotentReleaseExecutorService == null) {
- readLockIdempotentReleaseExecutorService = camelContext.getExecutorServiceManager().newScheduledThreadPool(this, "ReadLockChangedIdempotentReleaseTask", readLockIdempotentReleaseAsyncPoolSize);
+ readLockIdempotentReleaseExecutorService = camelContext.getExecutorServiceManager().newScheduledThreadPool(
+ this, "ReadLockChangedIdempotentReleaseTask", readLockIdempotentReleaseAsyncPoolSize);
shutdownExecutorService = true;
}
}
--
To stop receiving notification emails like this one, please contact
davsclaus@apache.org.