You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "AnmolSun (via GitHub)" <gi...@apache.org> on 2024/01/15 09:45:19 UTC

[PR] HIVE-27993 : Netty4 ShuffleHandler: should use 1 boss thread [hive]

AnmolSun opened a new pull request, #5006:
URL: https://github.com/apache/hive/pull/5006

   Similar to Tez [TEZ-4394](https://issues.apache.org/jira/browse/TEZ-4394), and [Hadoop](https://github.com/apache/hadoop/blob/7a0903b7436e7f3fb4f07c40bed2218a2653ba38/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java#L353), [Hive LLAP ShuffleHandler](https://github.com/apache/hive/blob/cc3f4d1d3b766f444606a4b06341eb8c4ae8148c/llap-server/src/java/org/apache/hadoop/hive/llap/shufflehandler/ShuffleHandler.java#L299) should also use a single thread for boss thread pool.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-27993 : Netty4 ShuffleHandler: should use 1 boss thread [hive]

Posted by "AnmolSun (via GitHub)" <gi...@apache.org>.
AnmolSun commented on PR #5006:
URL: https://github.com/apache/hive/pull/5006#issuecomment-1903981732

   Thanks for helping with review @zhangbutao 
   Rebased and now we have a green run!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-27993 : Netty4 ShuffleHandler: should use 1 boss thread [hive]

Posted by "zhangbutao (via GitHub)" <gi...@apache.org>.
zhangbutao commented on PR #5006:
URL: https://github.com/apache/hive/pull/5006#issuecomment-1906185225

   @abstractdog Could you please take a look as well? Thx.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-27993 : Netty4 ShuffleHandler: should use 1 boss thread [hive]

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #5006:
URL: https://github.com/apache/hive/pull/5006#issuecomment-1903688283

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5006) **Quality Gate passed**  
   Kudos, no new issues were introduced!
   
   [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5006&resolved=false&inNewCodePeriod=true)  
   [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5006&resolved=false&inNewCodePeriod=true)  
   No data about Coverage  
   No data about Duplication  
     
   [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5006)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-27993 : Netty4 ShuffleHandler: should use 1 boss thread [hive]

Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog merged PR #5006:
URL: https://github.com/apache/hive/pull/5006


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org