You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2025/01/23 13:55:26 UTC

[PR] Remove `slf4j-api` reference in `LICENSE` (#12052) [iceberg]

Fokko opened a new pull request, #12068:
URL: https://github.com/apache/iceberg/pull/12068

   Work by @jbonofre, let's include this in 1.7.2 as well:
   
   I've checked out the branch, and it is also excluded from the JAR on the `1.7.x` branch:
   ```
   ➜  azure find . | grep -i slf4j
   ./org/apache/iceberg/azure/shaded/io/netty/util/internal/logging/LocationAwareSlf4JLogger.class
   ./org/apache/iceberg/azure/shaded/io/netty/util/internal/logging/Slf4JLoggerFactory$NopInstanceHolder.class
   ./org/apache/iceberg/azure/shaded/io/netty/util/internal/logging/Slf4JLoggerFactory.class
   ./org/apache/iceberg/azure/shaded/io/netty/util/internal/logging/Slf4JLogger.class
   ./reactor/util/Loggers$Slf4JLoggerFactory.class
   ./reactor/util/Loggers$Slf4JLogger.class
   ```
   
   ```
   ➜  gcp find . | grep -i slf4j                                                                               
   ./io/grpc/netty/shaded/io/netty/util/internal/logging/LocationAwareSlf4JLogger.class
   ./io/grpc/netty/shaded/io/netty/util/internal/logging/Slf4JLoggerFactory$NopInstanceHolder.class
   ./io/grpc/netty/shaded/io/netty/util/internal/logging/Slf4JLoggerFactory.class
   ./io/grpc/netty/shaded/io/netty/util/internal/logging/Slf4JLogger.class
   ```
   
   ```
   ➜  aws find . | grep -i slf4j                     
   ./org/apache/iceberg/aws/shaded/io/netty/util/internal/logging/LocationAwareSlf4JLogger.class
   ./org/apache/iceberg/aws/shaded/io/netty/util/internal/logging/Slf4JLoggerFactory$NopInstanceHolder.class
   ./org/apache/iceberg/aws/shaded/io/netty/util/internal/logging/Slf4JLoggerFactory.class
   ./org/apache/iceberg/aws/shaded/io/netty/util/internal/logging/Slf4JLogger.class
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Remove `slf4j-api` reference in `LICENSE` (#12052) [iceberg]

Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue commented on PR #12068:
URL: https://github.com/apache/iceberg/pull/12068#issuecomment-2611053977

   Thanks, @Fokko and @jbonofre!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Remove `slf4j-api` reference in `LICENSE` (#12052) [iceberg]

Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer commented on PR #12068:
URL: https://github.com/apache/iceberg/pull/12068#issuecomment-2611045376

   Thanks @Fokko and @jbonofre for cleaning all this up!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Remove `slf4j-api` reference in `LICENSE` (#12052) [iceberg]

Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer merged PR #12068:
URL: https://github.com/apache/iceberg/pull/12068


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org