You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/05/11 11:34:44 UTC

[GitHub] [rocketmq] Git-Yang opened a new pull request #2866: [ISSUE #2865] Batch message send bug fix

Git-Yang opened a new pull request #2866:
URL: https://github.com/apache/rocketmq/pull/2866


   ## What is the purpose of the change
   Fix the problem of failing to build consumption index when sending batch messages, resulting in inability to consume.
   
   ## Brief changelog
   1. Asynchronous batch write: add queueOffset in the inner layer of lock.
   2. Synchronous writing: serialize the message in the outer layer of the lock, and supplement the queueOffset in the inner layer of the lock.
   
   
   ## Verifying this change
   
   XXXX
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] Git-Yang commented on pull request #2866: [ISSUE #2865] Batch message send bug fix

Posted by GitBox <gi...@apache.org>.
Git-Yang commented on pull request #2866:
URL: https://github.com/apache/rocketmq/pull/2866#issuecomment-840386022


   经过batch测试，发现在serialize中构建queueOffsetKey存在并发问题，详见[ISSUE](https://github.com/apache/rocketmq/issues/2865)评论补充


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] vongosling merged pull request #2866: [ISSUE #2865] Batch message send bug fix

Posted by GitBox <gi...@apache.org>.
vongosling merged pull request #2866:
URL: https://github.com/apache/rocketmq/pull/2866


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #2866: [ISSUE #2865] Batch message send bug fix

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2866:
URL: https://github.com/apache/rocketmq/pull/2866#issuecomment-838340710


   
   [![Coverage Status](https://coveralls.io/builds/39570104/badge)](https://coveralls.io/builds/39570104)
   
   Coverage increased (+0.06%) to 51.9% when pulling **cd82fcb90dceb18a34cc92957d1e4634403c7f20 on Git-Yang:batch_msg_bug_fix** into **b4240d5cea8d001c21b9c0d73f5aa700fcd0d568 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls edited a comment on pull request #2866: [ISSUE #2865] Batch message send bug fix

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2866:
URL: https://github.com/apache/rocketmq/pull/2866#issuecomment-838340710


   
   [![Coverage Status](https://coveralls.io/builds/39651102/badge)](https://coveralls.io/builds/39651102)
   
   Coverage decreased (-0.08%) to 51.754% when pulling **8613db747d821e91800cc1c6a3a22c4fe79e0ed1 on Git-Yang:batch_msg_bug_fix** into **b4240d5cea8d001c21b9c0d73f5aa700fcd0d568 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] duhenglucky commented on pull request #2866: [ISSUE #2865] Batch message send bug fix

Posted by GitBox <gi...@apache.org>.
duhenglucky commented on pull request #2866:
URL: https://github.com/apache/rocketmq/pull/2866#issuecomment-844644630


   @Git-Yang Please change the target branch to develop, we will merge this PR ASAP.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls edited a comment on pull request #2866: [ISSUE #2865] Batch message send bug fix

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2866:
URL: https://github.com/apache/rocketmq/pull/2866#issuecomment-838340710


   
   [![Coverage Status](https://coveralls.io/builds/39651030/badge)](https://coveralls.io/builds/39651030)
   
   Coverage increased (+0.08%) to 51.914% when pulling **8613db747d821e91800cc1c6a3a22c4fe79e0ed1 on Git-Yang:batch_msg_bug_fix** into **b4240d5cea8d001c21b9c0d73f5aa700fcd0d568 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org