You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stdcxx.apache.org by Farid Zaripov <Fa...@epam.com> on 2007/08/01 20:37:57 UTC
[PATCH] gencat.cpp (was: RE: svn commit: r555006 - /incubator/stdcxx/trunk/src/catalog.cpp)
> -----Original Message-----
> From: Martin Sebor [mailto:sebor@roguewave.com]
> Sent: Friday, July 13, 2007 5:53 PM
> To: stdcxx-dev@incubator.apache.org
> Subject: Re: svn commit: r555006 -
> /incubator/stdcxx/trunk/src/catalog.cpp
>
> >> If it does, is the bug easily
> >> reproducible so we can add a test case for it to the bug tracking
> >> database?
The JIRA issue created: http://issues.apache.org/jira/browse/STDCXX-508
> > For the test case the valid catalog should be created
> (.dll file on
> > windows).
> > It's not so easy and platform dependent. Of course we can use
> > generate_catalog () function from 22.locale.messages.cpp test.
>
> That seems like a good approach. We could use it as the first
> step toward providing an easier and portable way to build
> message catalogs on Windows as well as other platforms. A
> portable utility that takes a source file such as
> rwstderr.msg or rwstderr.rc as input and produces a catalog
> from it suitable for the target platform.
Attached is a new utility for generating the message catalogs on Windows.
ChangeLog:
* gencat.cpp: New utility for generating the message catalogs on Windows.
Farid.
Re: [PATCH] gencat.cpp
Posted by Martin Sebor <se...@roguewave.com>.
Farid Zaripov wrote:
>> -----Original Message-----
>> From: Martin Sebor [mailto:sebor@roguewave.com]
>> Sent: Friday, August 03, 2007 2:03 AM
>> To: stdcxx-dev@incubator.apache.org
>> Subject: Re: [PATCH] gencat.cpp (was: RE: svn commit: r555006
>> - /incubator/stdcxx/trunk/src/catalog.cpp)
>>
>> This looks good, although it could use a few more comments :)
>>
>> Where does it live? In $TOPDIR/util/?
> Yes.
>
>> Does the conditional #error cause any problems on UNIX?
> We can exclude this file from compilation (the same way as
> excluded rwstdmessages.cpp in makefile.exm).
>
>> Would it be safer to implement it on UNIX as well by having it
>> invoke the system gencat utility?
> Yes we can do it, but with renaming the utility to, for example,
> rwgencat
> to avoid invoking the utility recursively.
Or by specifying the full pathname when invoking the system
gencat utility. Or simply by removing $BUILDDIR/bin from PATH
if it's there.
If you think this approach will work I would favor it over
changing the makefiles and avoiding building the utility on
UNIX.
Does anyone have any concerns or suggestions? Andrew? Travis?
Martin
RE: [PATCH] gencat.cpp (was: RE: svn commit: r555006 - /incubator/stdcxx/trunk/src/catalog.cpp)
Posted by Farid Zaripov <Fa...@epam.com>.
> -----Original Message-----
> From: Martin Sebor [mailto:sebor@roguewave.com]
> Sent: Friday, August 03, 2007 2:03 AM
> To: stdcxx-dev@incubator.apache.org
> Subject: Re: [PATCH] gencat.cpp (was: RE: svn commit: r555006
> - /incubator/stdcxx/trunk/src/catalog.cpp)
>
> This looks good, although it could use a few more comments :)
>
> Where does it live? In $TOPDIR/util/?
Yes.
> Does the conditional #error cause any problems on UNIX?
We can exclude this file from compilation (the same way as
excluded rwstdmessages.cpp in makefile.exm).
> Would it be safer to implement it on UNIX as well by having it
> invoke the system gencat utility?
Yes we can do it, but with renaming the utility to, for example,
rwgencat
to avoid invoking the utility recursively.
Farid.
Re: [PATCH] gencat.cpp (was: RE: svn commit: r555006 - /incubator/stdcxx/trunk/src/catalog.cpp)
Posted by Martin Sebor <se...@roguewave.com>.
This looks good, although it could use a few more comments :)
Where does it live? In $TOPDIR/util/? Does the conditional #error
cause any problems on UNIX? Would it be safer to implement it on
UNIX as well by having it invoke the system gencat utility?
Martin
Farid Zaripov wrote:
> > -----Original Message-----
> > From: Martin Sebor [mailto:sebor@roguewave.com]
> > Sent: Friday, July 13, 2007 5:53 PM
> > To: stdcxx-dev@incubator.apache.org
> > Subject: Re: svn commit: r555006 -
> > /incubator/stdcxx/trunk/src/catalog.cpp
> >
> > >> If it does, is the bug easily
> > >> reproducible so we can add a test case for it to the bug tracking
> > >> database?
>
> The JIRA issue created: http://issues.apache.org/jira/browse/STDCXX-508
>
> > > For the test case the valid catalog should be created
> > (.dll file on
> > > windows).
> > > It's not so easy and platform dependent. Of course we can use
> > > generate_catalog () function from 22.locale.messages.cpp test.
> >
> > That seems like a good approach. We could use it as the first
> > step toward providing an easier and portable way to build
> > message catalogs on Windows as well as other platforms. A
> > portable utility that takes a source file such as
> > rwstderr.msg or rwstderr.rc as input and produces a catalog
> > from it suitable for the target platform.
>
> Attached is a new utility for generating the message catalogs on Windows.
>
> ChangeLog:
> * gencat.cpp: New utility for generating the message catalogs on Windows.
>
> Farid.
>