You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Saman Alvi <sa...@pivotal.io> on 2014/10/21 19:50:05 UTC
Review Request 26986: Confirmation dialogues needs clearer messages
regarding actions on services
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26986/
-----------------------------------------------------------
Review request for Ambari.
Bugs: AMBARI-7663
https://issues.apache.org/jira/browse/AMBARI-7663
Repository: ambari
Description
-------
Confirmation dialogues needs clearer messages regarding actions on services
Diffs
-----
ambari-web/app/controllers/main/service.js 0566612
ambari-web/app/controllers/main/service/item.js 8990a39
ambari-web/app/messages.js 4008fbc
ambari-web/test/controllers/main/service/item_test.js 4f94eda
ambari-web/test/controllers/main/service_test.js 808bbe7
Diff: https://reviews.apache.org/r/26986/diff/
Testing
-------
Thanks,
Saman Alvi
Re: Review Request 26986: Confirmation dialogues needs clearer
messages regarding actions on services
Posted by Grace Li <gl...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26986/#review57619
-----------------------------------------------------------
Ship it!
Ship It!
- Grace Li
On Oct. 21, 2014, 5:50 p.m., Saman Alvi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26986/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2014, 5:50 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-7663
> https://issues.apache.org/jira/browse/AMBARI-7663
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Confirmation dialogues needs clearer messages regarding actions on services
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service.js 0566612
> ambari-web/app/controllers/main/service/item.js 8990a39
> ambari-web/app/messages.js 4008fbc
> ambari-web/test/controllers/main/service/item_test.js 4f94eda
> ambari-web/test/controllers/main/service_test.js 808bbe7
>
> Diff: https://reviews.apache.org/r/26986/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Saman Alvi
>
>
Re: Review Request 26986: Confirmation dialogues needs clearer
messages regarding actions on services
Posted by Ivan Wang <yi...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26986/#review57996
-----------------------------------------------------------
Ship it!
Ship It!
- Ivan Wang
On Oct. 21, 2014, 5:50 p.m., Saman Alvi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26986/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2014, 5:50 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-7663
> https://issues.apache.org/jira/browse/AMBARI-7663
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Confirmation dialogues needs clearer messages regarding actions on services
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service.js 0566612
> ambari-web/app/controllers/main/service/item.js 8990a39
> ambari-web/app/messages.js 4008fbc
> ambari-web/test/controllers/main/service/item_test.js 4f94eda
> ambari-web/test/controllers/main/service_test.js 808bbe7
>
> Diff: https://reviews.apache.org/r/26986/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Saman Alvi
>
>
Re: Review Request 26986: Confirmation dialogues needs clearer
messages regarding actions on services
Posted by Saman Alvi <sa...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26986/
-----------------------------------------------------------
(Updated Oct. 21, 2014, 5:50 p.m.)
Review request for Ambari.
Bugs: AMBARI-7663
https://issues.apache.org/jira/browse/AMBARI-7663
Repository: ambari
Description
-------
Confirmation dialogues needs clearer messages regarding actions on services
Diffs
-----
ambari-web/app/controllers/main/service.js 0566612
ambari-web/app/controllers/main/service/item.js 8990a39
ambari-web/app/messages.js 4008fbc
ambari-web/test/controllers/main/service/item_test.js 4f94eda
ambari-web/test/controllers/main/service_test.js 808bbe7
Diff: https://reviews.apache.org/r/26986/diff/
Testing
-------
Thanks,
Saman Alvi