You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "robertwb (via GitHub)" <gi...@apache.org> on 2023/04/18 19:16:32 UTC
[GitHub] [beam] robertwb opened a new pull request, #26332: Use plain Impulse rather than a full Read for 0, 1 element Creates.
robertwb opened a new pull request, #26332:
URL: https://github.com/apache/beam/pull/26332
Most of the complexity here is in preserving the read for update compatibility.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #26332: Use plain Impulse rather than a full Read for 0, 1 element Creates.
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb commented on PR #26332:
URL: https://github.com/apache/beam/pull/26332#issuecomment-1629271292
There was a test failure I needed to investigate, and it never got to the
top of the "urgent" pile. I plan on wrapping this up now that I'm back from
vacation.
On Mon, Jul 10, 2023 at 8:08 AM Kenn Knowles ***@***.***>
wrote:
> Wasn't this demonstrated to have an improvement? I honestly thought this
> had been merged.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/26332#issuecomment-1629161050>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AADWVAOYQER2XR5I2PPJ5S3XPQLF3ANCNFSM6AAAAAAXDCAJGA>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26332: Use plain Impulse rather than a full Read for 0, 1 element Creates.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26332:
URL: https://github.com/apache/beam/pull/26332#issuecomment-1533373073
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #26332: Use plain Impulse rather than a full Read for 0, 1 element Creates.
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb commented on PR #26332:
URL: https://github.com/apache/beam/pull/26332#issuecomment-1629801706
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26332: Use plain Impulse rather than a full Read for 0, 1 element Creates.
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26332:
URL: https://github.com/apache/beam/pull/26332#issuecomment-1522277251
We hit some bugs with the overhead of Read and splitting too much when there is really no point in splitting at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26332: Use plain Impulse rather than a full Read for 0, 1 element Creates.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26332:
URL: https://github.com/apache/beam/pull/26332#issuecomment-1513733320
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @Abacn for label java.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26332: Use plain Impulse rather than a full Read for 0, 1 element Creates.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26332:
URL: https://github.com/apache/beam/pull/26332#issuecomment-1618195094
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26332: Use plain Impulse rather than a full Read for 0, 1 element Creates.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26332:
URL: https://github.com/apache/beam/pull/26332#issuecomment-1532920864
Reminder, please take a look at this pr: @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26332: Use plain Impulse rather than a full Read for 0, 1 element Creates.
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26332:
URL: https://github.com/apache/beam/pull/26332#issuecomment-1629161050
Wasn't this demonstrated to have an improvement? I honestly thought this had been merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb merged pull request #26332: Use plain Impulse rather than a full Read for 0, 1 element Creates.
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb merged PR #26332:
URL: https://github.com/apache/beam/pull/26332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26332: Use plain Impulse rather than a full Read for 0, 1 element Creates.
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26332:
URL: https://github.com/apache/beam/pull/26332#issuecomment-1533372457
Please run spotless and push it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26332: Use plain Impulse rather than a full Read for 0, 1 element Creates.
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26332:
URL: https://github.com/apache/beam/pull/26332#issuecomment-1533371683
R: @kennknowles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #26332: Use plain Impulse rather than a full Read for 0, 1 element Creates.
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26332:
URL: https://github.com/apache/beam/pull/26332#issuecomment-1521930001
Thanks, just curious was there an issue reading 0, 1 elements or what is the advantage of switching to Impulse?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26332: Use plain Impulse rather than a full Read for 0, 1 element Creates.
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26332:
URL: https://github.com/apache/beam/pull/26332#issuecomment-1522280772
better get tests green and VR tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #26332: Use plain Impulse rather than a full Read for 0, 1 element Creates.
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb commented on PR #26332:
URL: https://github.com/apache/beam/pull/26332#issuecomment-1633353888
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org