You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Mario Salazar de Torres <ma...@est.tech> on 2020/09/30 09:08:32 UTC
PRs to review in geode-native
Hi everyone,
I've created 2 PR in geode-native repository:
* https://github.com/apache/geode-native/pull/659
* https://github.com/apache/geode-native/pull/660
If any of you could take some time to throw some comments on them, I would be so much appreciated.
PST. It's my first time contributing to the project, so please don't be too mean with me ha-ha 😉
Thanks!
BR/Mario
Re: PRs to review in geode-native
Posted by Mario Salazar de Torres <ma...@est.tech>.
Hi Blake,
I am hoping opening a PR to support my initial test proposal is off the table, right? If so, give me a couple of days and I will think of alternatives.
If nothing comes to my mind, then I'll reach you back.
Thanks btw for merging PR #667
BR,
Mario.
________________________________
From: Blake Bender <bb...@vmware.com>
Sent: Tuesday, October 27, 2020 6:25 PM
To: dev@geode.apache.org <de...@geode.apache.org>
Subject: Re: PRs to review in geode-native
I've asked mreddington to re-review today. I think we're still hoping to have a test for this, though, right?
On 10/27/20, 5:51 AM, "Mario Salazar de Torres" <ma...@est.tech> wrote:
Hi everyone,
Thanks everyone involved for merging PR #659<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode-native%2Fpull%2F659&data=04%7C01%7Cbblake%40vmware.com%7C638426e25e644d6ad82508d87a76f590%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637393998640926274%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=%2F3gELhN0B2XBC5pngQv1A0WLhaCoenMZVnCFaUOM7oM%3D&reserved=0>.
Thing is that it has been a while since #660<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode-native%2Fpull%2F660&data=04%7C01%7Cbblake%40vmware.com%7C638426e25e644d6ad82508d87a76f590%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637393998640926274%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=59wr1HMHQhNOvMczV%2FNeq5yDo1n1jz6jDQOD%2BNlXCXI%3D&reserved=0> got any feedback.
Is there any chance you could reserve some time to give me some feedback on it?
Thanks for all.
BR,
Mario.
________________________________
From: Blake Bender <bb...@vmware.com>
Sent: Wednesday, September 30, 2020 4:34 PM
To: dev@geode.apache.org <de...@geode.apache.org>
Subject: Re: PRs to review in geode-native
We'll get on these today, no worries.
Thanks,
Blake
On 9/30/20, 2:08 AM, "Mario Salazar de Torres" <ma...@est.tech> wrote:
Hi everyone,
I've created 2 PR in geode-native repository:
* https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode-native%2Fpull%2F659&data=04%7C01%7Cbblake%40vmware.com%7C638426e25e644d6ad82508d87a76f590%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637393998640926274%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=%2F3gELhN0B2XBC5pngQv1A0WLhaCoenMZVnCFaUOM7oM%3D&reserved=0
* https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode-native%2Fpull%2F660&data=04%7C01%7Cbblake%40vmware.com%7C638426e25e644d6ad82508d87a76f590%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637393998640926274%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=59wr1HMHQhNOvMczV%2FNeq5yDo1n1jz6jDQOD%2BNlXCXI%3D&reserved=0
If any of you could take some time to throw some comments on them, I would be so much appreciated.
PST. It's my first time contributing to the project, so please don't be too mean with me ha-ha 😉
Thanks!
BR/Mario
Re: PRs to review in geode-native
Posted by Blake Bender <bb...@vmware.com>.
I've asked mreddington to re-review today. I think we're still hoping to have a test for this, though, right?
On 10/27/20, 5:51 AM, "Mario Salazar de Torres" <ma...@est.tech> wrote:
Hi everyone,
Thanks everyone involved for merging PR #659<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode-native%2Fpull%2F659&data=04%7C01%7Cbblake%40vmware.com%7C638426e25e644d6ad82508d87a76f590%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637393998640926274%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=%2F3gELhN0B2XBC5pngQv1A0WLhaCoenMZVnCFaUOM7oM%3D&reserved=0>.
Thing is that it has been a while since #660<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode-native%2Fpull%2F660&data=04%7C01%7Cbblake%40vmware.com%7C638426e25e644d6ad82508d87a76f590%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637393998640926274%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=59wr1HMHQhNOvMczV%2FNeq5yDo1n1jz6jDQOD%2BNlXCXI%3D&reserved=0> got any feedback.
Is there any chance you could reserve some time to give me some feedback on it?
Thanks for all.
BR,
Mario.
________________________________
From: Blake Bender <bb...@vmware.com>
Sent: Wednesday, September 30, 2020 4:34 PM
To: dev@geode.apache.org <de...@geode.apache.org>
Subject: Re: PRs to review in geode-native
We'll get on these today, no worries.
Thanks,
Blake
On 9/30/20, 2:08 AM, "Mario Salazar de Torres" <ma...@est.tech> wrote:
Hi everyone,
I've created 2 PR in geode-native repository:
* https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode-native%2Fpull%2F659&data=04%7C01%7Cbblake%40vmware.com%7C638426e25e644d6ad82508d87a76f590%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637393998640926274%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=%2F3gELhN0B2XBC5pngQv1A0WLhaCoenMZVnCFaUOM7oM%3D&reserved=0
* https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode-native%2Fpull%2F660&data=04%7C01%7Cbblake%40vmware.com%7C638426e25e644d6ad82508d87a76f590%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637393998640926274%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=59wr1HMHQhNOvMczV%2FNeq5yDo1n1jz6jDQOD%2BNlXCXI%3D&reserved=0
If any of you could take some time to throw some comments on them, I would be so much appreciated.
PST. It's my first time contributing to the project, so please don't be too mean with me ha-ha 😉
Thanks!
BR/Mario
Re: PRs to review in geode-native
Posted by Mario Salazar de Torres <ma...@est.tech>.
Hi everyone,
Thanks everyone involved for merging PR #659<https://github.com/apache/geode-native/pull/659>.
Thing is that it has been a while since #660<https://github.com/apache/geode-native/pull/660> got any feedback.
Is there any chance you could reserve some time to give me some feedback on it?
Thanks for all.
BR,
Mario.
________________________________
From: Blake Bender <bb...@vmware.com>
Sent: Wednesday, September 30, 2020 4:34 PM
To: dev@geode.apache.org <de...@geode.apache.org>
Subject: Re: PRs to review in geode-native
We'll get on these today, no worries.
Thanks,
Blake
On 9/30/20, 2:08 AM, "Mario Salazar de Torres" <ma...@est.tech> wrote:
Hi everyone,
I've created 2 PR in geode-native repository:
* https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode-native%2Fpull%2F659&data=02%7C01%7Cbblake%40vmware.com%7Cdc2d4126f8404c610e7f08d865206ef0%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637370537265990061&sdata=T7mRZ6%2B01yd6wOUmbE2s2Q%2FWAOM63E9ZE%2FSBbrB1wmk%3D&reserved=0
* https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode-native%2Fpull%2F660&data=02%7C01%7Cbblake%40vmware.com%7Cdc2d4126f8404c610e7f08d865206ef0%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637370537265990061&sdata=%2F0XPvKcup8OcgnG8bfvJ1b0ZTkJTb4IztbsooCsKto0%3D&reserved=0
If any of you could take some time to throw some comments on them, I would be so much appreciated.
PST. It's my first time contributing to the project, so please don't be too mean with me ha-ha 😉
Thanks!
BR/Mario
Re: PRs to review in geode-native
Posted by Blake Bender <bb...@vmware.com>.
We'll get on these today, no worries.
Thanks,
Blake
On 9/30/20, 2:08 AM, "Mario Salazar de Torres" <ma...@est.tech> wrote:
Hi everyone,
I've created 2 PR in geode-native repository:
* https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode-native%2Fpull%2F659&data=02%7C01%7Cbblake%40vmware.com%7Cdc2d4126f8404c610e7f08d865206ef0%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637370537265990061&sdata=T7mRZ6%2B01yd6wOUmbE2s2Q%2FWAOM63E9ZE%2FSBbrB1wmk%3D&reserved=0
* https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode-native%2Fpull%2F660&data=02%7C01%7Cbblake%40vmware.com%7Cdc2d4126f8404c610e7f08d865206ef0%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637370537265990061&sdata=%2F0XPvKcup8OcgnG8bfvJ1b0ZTkJTb4IztbsooCsKto0%3D&reserved=0
If any of you could take some time to throw some comments on them, I would be so much appreciated.
PST. It's my first time contributing to the project, so please don't be too mean with me ha-ha 😉
Thanks!
BR/Mario