You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "ulysses-you (via GitHub)" <gi...@apache.org> on 2023/08/25 09:52:22 UTC
[GitHub] [incubator-celeborn] ulysses-you opened a new pull request, #1842: [CELEBORN-922] Improve celeborn shuffle maanger fallback log message
ulysses-you opened a new pull request, #1842:
URL: https://github.com/apache/incubator-celeborn/pull/1842
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
When celeborn shuffle maanger fallback to vanilla Spark shuffle manager, we should make sure the DRA is disabled, otherwise the reduer task may fail when fetching block.
This pr improves the log to use error level to print fallback message if DRA is enabled.
### Why are the changes needed?
Improve the log message.
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
PASS CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture closed pull request #1842: [CELEBORN-922] Improve celeborn shuffle maanger fallback log message
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #1842: [CELEBORN-922] Improve celeborn shuffle maanger fallback log message
URL: https://github.com/apache/incubator-celeborn/pull/1842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1842: [CELEBORN-922] Improve celeborn shuffle maanger fallback log message
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1842:
URL: https://github.com/apache/incubator-celeborn/pull/1842#issuecomment-1693124247
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1842?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1842](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1842?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a167b63) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/b3700dd169198af3982ff3525624eec2c1a59597?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b3700dd) will **decrease** coverage by `0.01%`.
> Report is 2 commits behind head on main.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1842 +/- ##
==========================================
- Coverage 46.48% 46.46% -0.01%
==========================================
Files 163 163
Lines 10143 10143
Branches 934 934
==========================================
- Hits 4714 4712 -2
- Misses 5118 5119 +1
- Partials 311 312 +1
```
[see 1 file with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1842/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org