You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2026/01/28 18:50:59 UTC
[Impala-ASF-CR] PROTOTYPE: libpfm demo
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23917
Change subject: PROTOTYPE: libpfm demo
......................................................................
PROTOTYPE: libpfm demo
This transplants / transforms some code from Google Benchmark
to use libpfm to collect hardware performance counters for the
current process. As a demo, this collects a counter for some
backend tests and prints it to the INFO log at the end.
This requires that the user have permissions to collect performance
counters. On Ubuntu, this requires /proc/sys/kernel/perf_event_paranoid
to be <= 2 (default is usually 4).
These counters could be useful for identifying cache misses and
TLB misses.
TODO:
- Add comments explaining that the code is adapted from Google Benchmark
and what actually changed from the original code
- Try to get hardware performance counters for an individual query,
convey back to the coordinator, and aggregate into the profile. This
may not be limited to the threads used by the query, so it is most
exact when doing single-query-at-a-time testing.
- Maybe a system-wide capability would be useful for concurrency testing.
Change-Id: I75172f69fba2b87bf97696583344830b6005158f
---
M CMakeLists.txt
M be/CMakeLists.txt
M be/src/service/unified-betest-main.cc
M be/src/util/CMakeLists.txt
A be/src/util/perf-counters.cc
A be/src/util/perf-counters.h
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
8 files changed, 459 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/23917/1
--
To view, visit http://gerrit.cloudera.org:8080/23917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I75172f69fba2b87bf97696583344830b6005158f
Gerrit-Change-Number: 23917
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] PROTOTYPE: libpfm demo
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23917
to look at the new patch set (#2).
Change subject: PROTOTYPE: libpfm demo
......................................................................
PROTOTYPE: libpfm demo
This transplants / transforms some code from Google Benchmark
to use libpfm to collect hardware performance counters for the
current process. As a demo, this collects a counter for some
backend tests and prints it to the INFO log at the end.
This requires that the user have permissions to collect performance
counters. On Ubuntu, this requires /proc/sys/kernel/perf_event_paranoid
to be <= 2 (default is usually 4).
These counters could be useful for identifying cache misses and
TLB misses.
TODO:
- Add comments explaining that the code is adapted from Google Benchmark
and what actually changed from the original code
- Try to get hardware performance counters for an individual query,
convey back to the coordinator, and aggregate into the profile. This
may not be limited to the threads used by the query, so it is most
exact when doing single-query-at-a-time testing.
- Maybe a system-wide capability would be useful for concurrency testing.
Change-Id: I75172f69fba2b87bf97696583344830b6005158f
---
M CMakeLists.txt
M be/CMakeLists.txt
M be/src/service/unified-betest-main.cc
M be/src/util/CMakeLists.txt
A be/src/util/perf-counters.cc
A be/src/util/perf-counters.h
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
A cmake_modules/FindLibPfm.cmake
9 files changed, 521 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/23917/2
--
To view, visit http://gerrit.cloudera.org:8080/23917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I75172f69fba2b87bf97696583344830b6005158f
Gerrit-Change-Number: 23917
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] PROTOTYPE: libpfm demo
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23917 )
Change subject: PROTOTYPE: libpfm demo
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/21521/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/23917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75172f69fba2b87bf97696583344830b6005158f
Gerrit-Change-Number: 23917
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Jan 2026 19:43:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] PROTOTYPE: libpfm demo
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23917 )
Change subject: PROTOTYPE: libpfm demo
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/21522/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75172f69fba2b87bf97696583344830b6005158f
Gerrit-Change-Number: 23917
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Jan 2026 21:00:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] PROTOTYPE: libpfm demo
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23917 )
Change subject: PROTOTYPE: libpfm demo
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/23917/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75172f69fba2b87bf97696583344830b6005158f
Gerrit-Change-Number: 23917
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Sep 2026 23:01:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] PROTOTYPE: libpfm demo
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/23917 )
Change subject: PROTOTYPE: libpfm demo
......................................................................
PROTOTYPE: libpfm demo
This transplants / transforms some code from Google Benchmark
to use libpfm to collect hardware performance counters for the
current process. As a demo, this collects a counter for some
backend tests and prints it to the INFO log at the end.
This requires that the user have permissions to collect performance
counters. On Ubuntu, this requires /proc/sys/kernel/perf_event_paranoid
to be <= 2 (default is usually 4).
These counters could be useful for identifying cache misses and
TLB misses.
TODO:
- Add comments explaining that the code is adapted from Google Benchmark
and what actually changed from the original code
- Try to get hardware performance counters for an individual query,
convey back to the coordinator, and aggregate into the profile. This
may not be limited to the threads used by the query, so it is most
exact when doing single-query-at-a-time testing.
- Maybe a system-wide capability would be useful for concurrency testing.
Change-Id: I75172f69fba2b87bf97696583344830b6005158f
---
M CMakeLists.txt
M be/CMakeLists.txt
M be/src/service/unified-betest-main.cc
M be/src/util/CMakeLists.txt
A be/src/util/perf-counters.cc
A be/src/util/perf-counters.h
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
A cmake_modules/FindLibPfm.cmake
9 files changed, 521 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/23917/3
--
To view, visit http://gerrit.cloudera.org:8080/23917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I75172f69fba2b87bf97696583344830b6005158f
Gerrit-Change-Number: 23917
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>