You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/12/18 19:06:58 UTC
Review Request 64685: Improved the comment around the union in
ns::clone().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64685/
-----------------------------------------------------------
Review request for mesos, Armand Grillet, Benjamin Bannier, and Michael Park.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/linux/ns.cpp 5e2df1ed56432c6c1bfa04a31dba7f9f547d6139
Diff: https://reviews.apache.org/r/64685/diff/1/
Testing
-------
See https://reviews.apache.org/r/64686/
Thanks,
Alexander Rukletsov
Re: Review Request 64685: Improved the comment around the union in
ns::clone().
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Dec. 22, 2017, 2:29 p.m., Benjamin Bannier wrote:
> > src/linux/ns.cpp
> > Line 320 (original), 320 (patched)
> > <https://reviews.apache.org/r/64685/diff/2/?file=1926496#file1926496line320>
> >
> > Since you are at it, could you make the first part a full sentence, e.g.,
> >
> > > _We_ need ...
Sure!
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64685/#review194427
-----------------------------------------------------------
On Dec. 22, 2017, 1:42 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64685/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2017, 1:42 p.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Bannier, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/linux/ns.cpp 5e2df1ed56432c6c1bfa04a31dba7f9f547d6139
>
>
> Diff: https://reviews.apache.org/r/64685/diff/2/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/64686/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 64685: Improved the comment around the union in
ns::clone().
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64685/#review194427
-----------------------------------------------------------
Fix it, then Ship it!
src/linux/ns.cpp
Line 320 (original), 320 (patched)
<https://reviews.apache.org/r/64685/#comment273194>
Since you are at it, could you make the first part a full sentence, e.g.,
> _We_ need ...
- Benjamin Bannier
On Dec. 22, 2017, 2:42 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64685/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2017, 2:42 p.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Bannier, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/linux/ns.cpp 5e2df1ed56432c6c1bfa04a31dba7f9f547d6139
>
>
> Diff: https://reviews.apache.org/r/64685/diff/2/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/64686/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 64685: Improved the comment around the union in
ns::clone().
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64685/
-----------------------------------------------------------
(Updated Dec. 22, 2017, 1:42 p.m.)
Review request for mesos, Armand Grillet, Benjamin Bannier, and Michael Park.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/linux/ns.cpp 5e2df1ed56432c6c1bfa04a31dba7f9f547d6139
Diff: https://reviews.apache.org/r/64685/diff/2/
Changes: https://reviews.apache.org/r/64685/diff/1-2/
Testing
-------
See https://reviews.apache.org/r/64686/
Thanks,
Alexander Rukletsov
Re: Review Request 64685: Improved the comment around the union in
ns::clone().
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64685/#review194089
-----------------------------------------------------------
Ship it!
Ship It!
- Armand Grillet
On Dec. 18, 2017, 7:06 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64685/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2017, 7:06 p.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Bannier, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/linux/ns.cpp 5e2df1ed56432c6c1bfa04a31dba7f9f547d6139
>
>
> Diff: https://reviews.apache.org/r/64685/diff/1/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/64686/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>