[GitHub] [ozone] smengcl commented on pull request #4297: HDDS-8006. [snapshot] Add unit test cases for snapshot delete

["smengcl (via GitHub)" <gi...@apache.org>]

smengcl commented on PR #4297:
URL: https://github.com/apache/ozone/pull/4297#issuecomment-1448853962

   > `TestOmSnapshot` (the class being changed) has failed:
   > 
   > * in @jyotirmoy-gh's fork for all 3 commits
   >   
   >   * https://github.com/jyotirmoy-gh/ozone/actions/runs/4242114172/jobs/7373203285#step:5:7810
   >   * https://github.com/jyotirmoy-gh/ozone/actions/runs/4242173232/jobs/7373337122#step:5:3336
   >   * https://github.com/jyotirmoy-gh/ozone/actions/runs/4242211689/jobs/7373428163#step:5:3336
   > * in the PR for both runs of the last commit (was cancelled in previous runs)
   >   
   >   * https://github.com/apache/ozone/actions/runs/4242212133/jobs/7373435640#step:5:3336
   >   * https://github.com/apache/ozone/actions/runs/4242212133/jobs/7474740898#step:5:3336
   > * and now on `master`:
   >   
   >   * https://github.com/apache/ozone/actions/runs/4296771836/jobs/7488905670#step:5:3383
   > 
   > Please do not merge with failing tests.
   
   Thanks @adoroszlai for pointing that out. Sorry about the trouble. Not sure how I could have missed that in the first place. (Subconsciously I thought the other +1 implied a green CI.) Will double check from now on.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org