You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/04/28 18:54:18 UTC
[GitHub] [netbeans] matthiasblaesing opened a new pull request, #4049: Improvements for LSP Client
matthiasblaesing opened a new pull request, #4049:
URL: https://github.com/apache/netbeans/pull/4049
Please see individual commits for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4049: Improvements for LSP Client
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4049:
URL: https://github.com/apache/netbeans/pull/4049#issuecomment-1113957639
> @matthiasblaesing , sorry for the delay (busy week).
No problem - thank you that you had a look at this!
> This looks sane to me. I love the `notifyFuture ... thenApply`. Pretty cool!
Yeah it matched perfectly - if I remember correctly @sdedic added it and turns out it is a very nice addition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on pull request #4049: Improvements for LSP Client
Posted by GitBox <gi...@apache.org>.
vieiro commented on PR #4049:
URL: https://github.com/apache/netbeans/pull/4049#issuecomment-1113934995
@matthiasblaesing , sorry for the delay (busy week).
This looks sane to me. I love the `notifyFuture ... thenApply`. Pretty cool!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4049: Improvements for LSP Client
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4049:
URL: https://github.com/apache/netbeans/pull/4049#issuecomment-1112571752
@jlahoda @vieiro could you please have a look at this and see if this looks sane to you? The intention is to fix the issue reported in #4034 without changing the API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #4049: Improvements for LSP Client
Posted by GitBox <gi...@apache.org>.
ebarboni commented on PR #4049:
URL: https://github.com/apache/netbeans/pull/4049#issuecomment-1113085752
Tested and seems to solve the issue, build check are green. Merging. Will build the rc2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni merged pull request #4049: Improvements for LSP Client
Posted by GitBox <gi...@apache.org>.
ebarboni merged PR #4049:
URL: https://github.com/apache/netbeans/pull/4049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists