[jira] Commented: (WICKET-1210) Proposal to remove 'final' modifier for PagingNavigationIncrementLink.getPageNumber()

["Igor Vaynberg (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551202 ] 

Igor Vaynberg commented on WICKET-1210:
---------------------------------------

to me this simply feels like the wrong place to remove final for this kind of code. could you please provide a quickstart that demonstrates the problem. thanks.

> Proposal to remove 'final' modifier for PagingNavigationIncrementLink.getPageNumber()
> -------------------------------------------------------------------------------------
>
>                 Key: WICKET-1210
>                 URL: https://issues.apache.org/jira/browse/WICKET-1210
>             Project: Wicket
>          Issue Type: Wish
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>            Reporter: Thomas Jaeckle
>            Assignee: Igor Vaynberg
>            Priority: Minor
>             Fix For: 1.3.0-rc3
>
>
> I wish to add a special behaviour to "PagingNavigationIncrementLink.getPageNumber()", which is final:
> http://www.nabble.com/PagingNavigationIncrementLink-special-behaviour-tf4935583.html
> Short: I extended "PagingNavigationIncrementLink.onClick()" so that more data is loaded from a service. After that I still want that the Page is changed, so I call "pageable.setCurrentPage(getPageNumber());".
> The "return Math.max(0, Math.min(pageable.getPageCount() - 1, idx));" breaks my neck because "pageable.getPageCount()" is missing the new added Page.
> It would be very helpful if PagingNavigationIncrementLink.getPageNumber() would not be final.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.