You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/11 09:02:12 UTC
[GitHub] [apisix] spacewander opened a new pull request #4218: test: make t/plugin/log-rotate.t stable
spacewander opened a new pull request #4218:
URL: https://github.com/apache/apisix/pull/4218
Signed-off-by: spacewander <sp...@gmail.com>
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #4218: test: make t/plugin/log-rotate.t stable
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #4218:
URL: https://github.com/apache/apisix/pull/4218#discussion_r630522069
##########
File path: t/plugin/log-rotate.t
##########
@@ -173,11 +173,13 @@ plugins:
end
end
- ngx.say(n_split_error_file)
+ -- Before hot reload, the log rotate may or may not take effect.
Review comment:
could we wait for some time before hot reload to make sure log rotate take effect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4218: test: make t/plugin/log-rotate.t stable
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4218:
URL: https://github.com/apache/apisix/pull/4218#discussion_r630643276
##########
File path: t/plugin/log-rotate.t
##########
@@ -173,11 +173,13 @@ plugins:
end
end
- ngx.say(n_split_error_file)
+ -- Before hot reload, the log rotate may or may not take effect.
Review comment:
We don't need to check if the rotation takes effect, it is checked by another test.
We only need to check if the rotation can be disabled, so there is no need to introduce extra sleep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers merged pull request #4218: test: make t/plugin/log-rotate.t stable
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #4218:
URL: https://github.com/apache/apisix/pull/4218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #4218: test: make t/plugin/log-rotate.t stable
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #4218:
URL: https://github.com/apache/apisix/pull/4218#discussion_r630645317
##########
File path: t/plugin/log-rotate.t
##########
@@ -173,11 +173,13 @@ plugins:
end
end
- ngx.say(n_split_error_file)
+ -- Before hot reload, the log rotate may or may not take effect.
Review comment:
Got it thanks for the explanation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org