You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "Bannirui (via GitHub)" <gi...@apache.org> on 2023/02/17 00:52:49 UTC
[GitHub] [incubator-eventmesh] Bannirui opened a new pull request, #3179: [ISSUE #3169] Replace `print` with `logger`
Bannirui opened a new pull request, #3179:
URL: https://github.com/apache/incubator-eventmesh/pull/3179
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #3169 .
### Modifications
To optimize `Code-Style`, locating at `org.apache.eventmesh.common.loadbalance.WeightRandomLoadBalanceSelectorTest`
- [X] Line 37: add `final` modifier
- [X] Line 49, 50, 72, 73: optimize spaces
- [X] Line 55: using `logger` ranter than `System.out.println`
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Bannirui commented on pull request #3179: [ISSUE #3169] Replace `print` with `logger`
Posted by "Bannirui (via GitHub)" <gi...@apache.org>.
Bannirui commented on PR #3179:
URL: https://github.com/apache/incubator-eventmesh/pull/3179#issuecomment-1434837183
> > @mxsm Done. However, in my opinion, use no lombok plugin if possible...
>
> @Bannirui The Lombok framework is widely used in the project, and it is also part of the project's specifications. Therefore, I believe in adhering to the project's specifications. If there is a need to cancel the use of the Lombok framework, I suggest discussing it within the community to determine if it is necessary to do so.
uh uh, it's just my view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #3179: [ISSUE #3169] Replace `print` with `logger`
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3179:
URL: https://github.com/apache/incubator-eventmesh/pull/3179#issuecomment-1433972284
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/3179?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3179](https://codecov.io/gh/apache/incubator-eventmesh/pull/3179?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (afa2d51) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/959d2b0a0b40a9f868ba10f2ebaac9960e4db1b3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (959d2b0) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head afa2d51 differs from pull request most recent head 37e31e6. Consider uploading reports for the commit 37e31e6 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3179 +/- ##
============================================
- Coverage 13.05% 13.04% -0.02%
Complexity 1145 1145
============================================
Files 548 548
Lines 28747 28738 -9
Branches 2857 2844 -13
============================================
- Hits 3754 3749 -5
+ Misses 24670 24668 -2
+ Partials 323 321 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/3179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ventmesh/client/grpc/util/EventMeshClientUtil.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2dycGMvdXRpbC9FdmVudE1lc2hDbGllbnRVdGlsLmphdmE=) | `91.20% <0.00%> (-0.34%)` | :arrow_down: |
| [...rg/apache/eventmesh/runtime/trace/LogExporter.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL3RyYWNlL0xvZ0V4cG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ime/admin/handler/RedirectClientByPathHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUmVkaXJlY3RDbGllbnRCeVBhdGhIYW5kbGVyLmphdmE=) | `84.78% <0.00%> (ø)` | |
| [...e/admin/handler/RedirectClientByIpPortHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUmVkaXJlY3RDbGllbnRCeUlwUG9ydEhhbmRsZXIuamF2YQ==) | `31.37% <0.00%> (ø)` | |
| [.../tcp/client/session/push/DownStreamMsgContext.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9zZXNzaW9uL3B1c2gvRG93blN0cmVhbU1zZ0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...l/tcp/client/recommend/EventMeshRecommendImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9yZWNvbW1lbmQvRXZlbnRNZXNoUmVjb21tZW5kSW1wbC5qYXZh) | `0.83% <0.00%> (+<0.01%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Bannirui closed pull request #3179: [ISSUE #3169] Replace `print` with `logger`
Posted by "Bannirui (via GitHub)" <gi...@apache.org>.
Bannirui closed pull request #3179: [ISSUE #3169] Replace `print` with `logger`
URL: https://github.com/apache/incubator-eventmesh/pull/3179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Bannirui commented on pull request #3179: [ISSUE #3169] Replace `print` with `logger`
Posted by "Bannirui (via GitHub)" <gi...@apache.org>.
Bannirui commented on PR #3179:
URL: https://github.com/apache/incubator-eventmesh/pull/3179#issuecomment-1434033026
@mxsm Done. However, in my opinion, use no lombok plugin if possible...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] mxsm commented on pull request #3179: [ISSUE #3169] Replace `print` with `logger`
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm commented on PR #3179:
URL: https://github.com/apache/incubator-eventmesh/pull/3179#issuecomment-1434642182
> @mxsm Done. However, in my opinion, use no lombok plugin if possible...
@Bannirui The Lombok framework is widely used in the project, and it is also part of the project's specifications. Therefore, I believe in adhering to the project's specifications. If there is a need to cancel the use of the Lombok framework, I suggest discussing it within the community to determine if it is necessary to do so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx merged pull request #3179: [ISSUE #3169] Replace `print` with `logger`
Posted by "jonyangx (via GitHub)" <gi...@apache.org>.
jonyangx merged PR #3179:
URL: https://github.com/apache/incubator-eventmesh/pull/3179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org